style(focus): avoid two spaces with "Focus on {view} View" when no view name is specified#296873
Open
kilianpaquier wants to merge 1 commit intomicrosoft:mainfrom
Open
style(focus): avoid two spaces with "Focus on {view} View" when no view name is specified#296873kilianpaquier wants to merge 1 commit intomicrosoft:mainfrom
kilianpaquier wants to merge 1 commit intomicrosoft:mainfrom
Conversation
…ew name is specified Signed-off-by: kilianpaquier <git@kilianpaquier.dev>
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @sandy081Matched files:
@benibenjMatched files:
@bpaseroMatched files:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Team 👋
A small pull request to not have two spaces when a viewDescriptor doesn't have a name. Might happen with extensions when the view "namespace" itself is self-sufficient (and to avoid duplication):
<Namespace>: Focus on <Namespace> View.Some examples (it's not bad but some extensions might choose to avoid this duplication):
Ports: Focus on Ports View.Chat: Focus on Chat View.Output: Focus on Output View.Problems: Focus on Problems View.