Support container scroll-state queries#488
Open
abdelfattahradwan wants to merge 1 commit into
Open
Conversation
Author
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #454
Summary
CSS container scroll-state queries such as
@container my-container scroll-state(scrollable: y)are valid syntax, but the parser currently treatsscroll-stateas invalid unless the query starts with a parenthesised size query orstyle(...).This PR adds parser support for
scroll-state(...)container queries while keeping the change focused to the existing@containerquery parsing path.This is my first pull request here, so I followed the format of #485.
Changes
src/parser/cssParser.tsscroll-state(...)as a valid container query formsrc/parser/cssParser.tsscroll-state(...)as container namessrc/test/css/parser.test.tssrc/test/scss/parser.test.tssrc/test/less/parser.test.tsTest plan
npm run test@media+ named@container ... scroll-state(scrollable: y)syntax parses without diagnostics@container scroll-state(scrollable: y)parses without treatingscroll-stateas a container namestyle(...), size-query, nested container, SCSS, and LESS parser behaviour continues to pass