Skip to content

[llfio] Fix build with [status-code] feature enabled.#51900

Draft
BillyONeal wants to merge 1 commit into
microsoft:masterfrom
BillyONeal:llfio-msvc-1951
Draft

[llfio] Fix build with [status-code] feature enabled.#51900
BillyONeal wants to merge 1 commit into
microsoft:masterfrom
BillyONeal:llfio-msvc-1951

Conversation

@BillyONeal
Copy link
Copy Markdown
Member

ned14/llfio#175

This cast is necessary to build on Visual Studio 2026 18.6.0 / MSVC 19.51 when llfio[status-code] is turned on

C:\Dev\vcpkg2\buildtrees\llfio\src\20260506-b0cb791d93.clean\include\llfio\v2.0\status_code.hpp(401,79): error C2440: 'default argument': cannot convert from 'system_error2::errc' to 'system_error2::system_code'
                     SYSTEM_ERROR2_NAMESPACE::system_code not_matched = errc::resource_unavailable_try_again) noexcept
                                                                              ^
C:\Dev\vcpkg2\buildtrees\llfio\src\20260506-b0cb791d93.clean\include\llfio\v2.0\status_code.hpp(401,79): note: No user-defined-conversion operator available that can perform this conversion, or the operator cannot be called

I'm not sure exactly why the implicit conversion isn't working on the default argument here :/

@BillyONeal BillyONeal added the depends:upstream-changes Waiting on a change to the upstream project label May 21, 2026
@BillyONeal
Copy link
Copy Markdown
Member Author

I'm not 100% positive on this one so I want upstream to comment before proceeding.

@BillyONeal BillyONeal marked this pull request as draft May 21, 2026 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

depends:upstream-changes Waiting on a change to the upstream project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant