Implement LSP-based code edits with file renaming

internal/diagnostics/extraDiagnosticMessages.json

@@ -122,5 +122,9 @@
     "Sort Imports": {
         "category": "Message",
         "code": 100018
+    },
+    "File rename is not supported by the editor": {
+        "category": "Error",
+        "code": 8040
     }
 }

internal/fourslash/_scripts/convertFourslash.mts

@@ -330,6 +330,8 @@ function parseFourslashStatement(statement: ts.Statement): Cmd[] {
                 case "renameInfoSucceeded":
                 case "renameInfoFailed":
                     return parseRenameInfo(func.text, callExpression.arguments);
+                case "getEditsForFileRename":
+                    return parseGetEditsForFileRename(callExpression.arguments);
                 case "getSemanticDiagnostics":
                 case "getSuggestionDiagnostics":
                 case "getSyntacticDiagnostics":
@@ -1429,6 +1431,83 @@ function parseRenameInfo(funcName: "renameInfoSucceeded" | "renameInfoFailed", a
     return [{ kind: funcName, preferences }];
 }
 
+function parseGetEditsForFileRename(args: readonly ts.Expression[]): [VerifyGetEditsForFileRenameCmd] {
+    if (args.length !== 1 || !ts.isObjectLiteralExpression(args[0])) {
+        throw new Error(`Expected a single object literal argument in verify.getEditsForFileRename, got ${args.map(arg => arg.getText()).join(", ")}`);
+    }
+
+    let oldPath: string | undefined;
+    let newPath: string | undefined;
+    let newFileContents = "map[string]string{}";
+    let preferences = "nil /*preferences*/";
+
+    for (const prop of args[0].properties) {
+        if (!ts.isPropertyAssignment(prop)) {
+            throw new Error(`Expected property assignment in verify.getEditsForFileRename argument, got ${prop.getText()}`);
+        }
+        const name = prop.name.getText();
+        switch (name) {
+            case "oldPath": {
+                const value = getStringLiteralLike(prop.initializer);
+                if (!value) {
+                    throw new Error(`Expected string literal for oldPath, got ${prop.initializer.getText()}`);
+                }
+                oldPath = getGoStringLiteral(value.text);
+                break;
+            }
+            case "newPath": {
+                const value = getStringLiteralLike(prop.initializer);
+                if (!value) {
+                    throw new Error(`Expected string literal for newPath, got ${prop.initializer.getText()}`);
+                }
+                newPath = getGoStringLiteral(value.text);
+                break;
+            }
+            case "newFileContents": {
+                const obj = getObjectLiteralExpression(prop.initializer);
+                if (!obj) {
+                    throw new Error(`Expected object literal for newFileContents, got ${prop.initializer.getText()}`);
+                }
+                const entries: string[] = [];
+                for (const entry of obj.properties) {
+                    if (!ts.isPropertyAssignment(entry)) {
+                        throw new Error(`Expected property assignment in verify.getEditsForFileRename argument, got ${prop.getText()}`);
+                    }
+                    const key = getStringLiteralLike(entry.name);
+                    const value = getStringLiteralLike(entry.initializer);
+                    if (!key || !value) {
+                        throw new Error(`Expected string literal key/value in newFileContents, got ${entry.getText()}`);
+                    }
+                    entries.push(`${getGoStringLiteral(key.text)}: ${getGoMultiLineStringLiteral(value.text)}`);
+                }
+                newFileContents = entries.length === 0
+                    ? "map[string]string{}"
+                    : `map[string]string{\n${entries.join(",\n")},\n}`;
+                break;
+            }
+            case "preferences": {
+                if (!ts.isObjectLiteralExpression(prop.initializer)) {
+                    throw new Error(`Expected object literal for preferences, got ${prop.initializer.getText()}`);
+                }
+                preferences = parseUserPreferences(prop.initializer);
+                break;
+            }
+        }
+    }
+
+    if (!oldPath || !newPath) {
+        throw new Error(`Expected oldPath and newPath in verify.getEditsForFileRename`);
+    }
+
+    return [{
+        kind: "verifyGetEditsForFileRename",
+        oldPath,
+        newPath,
+        newFileContents,
+        preferences,
+    }];
+}
+
 function parseBaselineRenameArgs(funcName: string, args: readonly ts.Expression[]): [VerifyBaselineRenameCmd] {
     let newArgs: string[] = [];
     let preferences: string | undefined;
@@ -3261,6 +3340,14 @@ interface VerifyRenameInfoCmd {
     preferences: string;
 }
 
+interface VerifyGetEditsForFileRenameCmd {
+    kind: "verifyGetEditsForFileRename";
+    oldPath: string;
+    newPath: string;
+    newFileContents: string;
+    preferences: string;
+}
+
 interface VerifyBaselineLinkedEditingCmd {
     kind: "verifyBaselineLinkedEditing";
 }
@@ -3413,6 +3500,7 @@ type Cmd =
     | VerifyOrganizeImportsCmd
     | VerifyBaselineRenameCmd
     | VerifyRenameInfoCmd
+    | VerifyGetEditsForFileRenameCmd
     | VerifyBaselineLinkedEditingCmd
     | VerifyLinkedEditingCmd
     | VerifyNavToCmd
@@ -3744,6 +3832,8 @@ function generateCmd(cmd: Cmd, imports: Set<string>): string {
             return `f.VerifyRenameSucceeded(t, ${cmd.preferences})`;
         case "renameInfoFailed":
             return `f.VerifyRenameFailed(t, ${cmd.preferences})`;
+        case "verifyGetEditsForFileRename":
+            return `f.VerifyWillRenameFilesEdits(t, ${cmd.oldPath}, ${cmd.newPath}, ${cmd.newFileContents}, ${cmd.preferences})`;
         case "verifyBaselineInlayHints":
             return generateBaselineInlayHints(cmd);
         case "verifyBaselineLinkedEditing":

internal/fourslash/_scripts/failingTests.txt

@@ -238,8 +238,6 @@ TestImportNameCodeFix_reExportDefault
 TestImportNameCodeFix_require
 TestImportNameCodeFix_require_addToExisting
 TestImportNameCodeFix_require_importVsRequire_addToExistingWins
-TestImportNameCodeFix_symlink_own_package
-TestImportNameCodeFix_symlink_own_package_2
 TestImportNameCodeFix_uriStyleNodeCoreModules2
 TestImportNameCodeFix_uriStyleNodeCoreModules3
 TestImportNameCodeFixDefaultExport4

internal/fourslash/_scripts/manualTests.txt

@@ -48,6 +48,16 @@ exhaustiveCaseCompletions6
 exhaustiveCaseCompletions7
 exhaustiveCaseCompletions8
 formatOnEnterInComment
+getEditsForFileRename_caseInsensitive
+getEditsForFileRename_directory_down
+getEditsForFileRename_directory_up
+getEditsForFileRename_jsExtension
+getEditsForFileRename_preferences
+getEditsForFileRename_preservePathEnding
+getEditsForFileRename_resolveJsonModule
+getEditsForFileRename_shortenRelativePaths
+getEditsForFileRename_subDir
+getEditsForFileRename_unaffectedNonRelativePath
 getOutliningSpans
 importNameCodeFix_uriStyleNodeCoreModules1
 importNameCodeFixDefaultExport7

internal/fourslash/_scripts/unparsedTests.txt

@@ -1664,35 +1664,6 @@ fsEditMarkerPositions.ts parse error: "Unrecognized verify content function: tex
 functionRenamingErrorRecovery.ts parse error: "Unrecognized fourslash statement: verify.not.errorExistsAfterMarker(...)"
 getCompletionEntryDetails.ts parse error: "Expected property access expression, got check"
 getCompletionEntryDetails2.ts parse error: "Expected property assignment with identifier name, got exact"
-getEditsForFileRename_ambientModule.ts parse error: "Unrecognized fourslash statement: verify.getEditsForFileRename(...)"
-getEditsForFileRename_amd.ts parse error: "Unrecognized fourslash statement: verify.getEditsForFileRename(...)"
-getEditsForFileRename_caseInsensitive.ts parse error: "Unrecognized fourslash statement: verify.getEditsForFileRename(...)"
-getEditsForFileRename_casing.ts parse error: "Unrecognized fourslash statement: verify.getEditsForFileRename(...)"
-getEditsForFileRename_directory_down.ts parse error: "Unrecognized fourslash statement: verify.getEditsForFileRename(...)"
-getEditsForFileRename_directory_noUpdateNodeModulesImport.ts parse error: "Unrecognized fourslash statement: verify.getEditsForFileRename(...)"
-getEditsForFileRename_directory_up.ts parse error: "Unrecognized fourslash statement: verify.getEditsForFileRename(...)"
-getEditsForFileRename_directory.ts parse error: "Unrecognized fourslash statement: verify.getEditsForFileRename(...)"
-getEditsForFileRename_js_simple.ts parse error: "Unrecognized fourslash statement: verify.getEditsForFileRename(...)"
-getEditsForFileRename_jsExtension.ts parse error: "Unrecognized fourslash statement: verify.getEditsForFileRename(...)"
-getEditsForFileRename_keepFileExtensions.ts parse error: "Unrecognized fourslash statement: verify.getEditsForFileRename(...)"
-getEditsForFileRename_nodeModuleDirectoryCase.ts parse error: "Unrecognized fourslash statement: verify.getEditsForFileRename(...)"
-getEditsForFileRename_notAffectedByJsFile.ts parse error: "Unrecognized fourslash statement: verify.getEditsForFileRename(...)"
-getEditsForFileRename_preferences.ts parse error: "Unrecognized fourslash statement: verify.getEditsForFileRename(...)"
-getEditsForFileRename_preservePathEnding.ts parse error: "Unrecognized fourslash statement: verify.getEditsForFileRename(...)"
-getEditsForFileRename_renameFromIndex.ts parse error: "Unrecognized fourslash statement: verify.getEditsForFileRename(...)"
-getEditsForFileRename_renameToIndex.ts parse error: "Unrecognized fourslash statement: verify.getEditsForFileRename(...)"
-getEditsForFileRename_resolveJsonModule.ts parse error: "Unrecognized fourslash statement: verify.getEditsForFileRename(...)"
-getEditsForFileRename_shortenRelativePaths.ts parse error: "Unrecognized fourslash statement: verify.getEditsForFileRename(...)"
-getEditsForFileRename_subDir.ts parse error: "Unrecognized fourslash statement: verify.getEditsForFileRename(...)"
-getEditsForFileRename_symlink.ts parse error: "Unrecognized fourslash statement: verify.getEditsForFileRename(...)"
-getEditsForFileRename_tsconfig_empty_include.ts parse error: "Unrecognized fourslash statement: verify.getEditsForFileRename(...)"
-getEditsForFileRename_tsconfig_include_add.ts parse error: "Unrecognized fourslash statement: verify.getEditsForFileRename(...)"
-getEditsForFileRename_tsconfig_include_noChange.ts parse error: "Unrecognized fourslash statement: verify.getEditsForFileRename(...)"
-getEditsForFileRename_tsconfig.ts parse error: "Unrecognized fourslash statement: verify.getEditsForFileRename(...)"
-getEditsForFileRename_unaffectedNonRelativePath.ts parse error: "Unrecognized fourslash statement: verify.getEditsForFileRename(...)"
-getEditsForFileRename_unresolvableImport.ts parse error: "Unrecognized fourslash statement: verify.getEditsForFileRename(...)"
-getEditsForFileRename_unresolvableNodeModule.ts parse error: "Unrecognized fourslash statement: verify.getEditsForFileRename(...)"
-getEditsForFileRename.ts parse error: "Unrecognized fourslash statement: verify.getEditsForFileRename(...)"
 getEmitOutputDeclarationMultiFiles.ts parse error: "Unrecognized fourslash statement: verify.baselineGetEmitOutput(...)"
 getEmitOutputDeclarationSingleFile.ts parse error: "Unrecognized fourslash statement: verify.baselineGetEmitOutput(...)"
 getEmitOutputExternalModule.ts parse error: "Unrecognized fourslash statement: verify.baselineGetEmitOutput(...)"