MADE TODO: fix/kplib rename to knowledge_schema and update imports#212
Merged
gvanrossum merged 1 commit intomicrosoft:mainfrom Mar 4, 2026
Merged
MADE TODO: fix/kplib rename to knowledge_schema and update imports#212gvanrossum merged 1 commit intomicrosoft:mainfrom
gvanrossum merged 1 commit intomicrosoft:mainfrom
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree |
gvanrossum
approved these changes
Mar 4, 2026
Collaborator
gvanrossum
left a comment
There was a problem hiding this comment.
Looks like you used AI to generate this change. There's nothing wrong with that (I use it too after all), but don't claim you're now a contributor. :-)
Contributor
Author
|
I only used it for the commit message and PR, but thank you, I admire you a lot. :) |
Collaborator
|
Okay great! Looking forward to more PRs from you. Just maybe don't copy-paste the AI output -- write it yourself. (I will fix mistakes in the description before I merge the commit.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kplib.pyto something ending in_schema.pySummary
Renamed kplib.py to knowledge_schema.py to make the filename more descriptive of its purpose as a schema definition file for knowledge extraction. Maintained compatibility by using as kplib alias in all imports.
Verification
✅ All tests pass successfully (make test)
Motivation
This change addresses the TODO item: "[P3, small] Rename kplib.py to something ending in _schema.py" . The new name knowledge_schema.py better reflects that the file contains schema definitions for knowledge extraction (entities, actions, topics, etc.) kplib.py:1-8 .
Compatibility
Full compatibility is maintained using the as kplib alias, so existing code using kplib. continues to work without changes.