Avoid List<T> allocation in Assert.ContainsSingle<T>#7537
Merged
Evangelink merged 1 commit intomainfrom Mar 12, 2026
Merged
Conversation
Replace .Where(predicate).ToList() with a manual foreach loop that counts matches and captures the first one. This avoids allocating a List<T> on every call. The non-generic overload already used this pattern.
Contributor
There was a problem hiding this comment.
Pull request overview
Replaces a LINQ .Where(predicate).ToList() allocation in Assert.ContainsSingle<T> with a manual foreach loop, matching the pattern already used by the non-generic overload.
Changes:
- Replace LINQ-based filtering with a manual loop that counts matches and captures the first one, avoiding a
List<T>allocation.
You can also share your feedback on Copilot code review. Take the survey.
Youssef1313
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace .Where(predicate).ToList() with a manual foreach loop that counts matches and captures the first one. This avoids allocating a List on every call. The non-generic overload already used this pattern.