Optimize CollectionAssert: hoist GetTypeInfo() and avoid redundant eumerations#7536
Open
Evangelink wants to merge 1 commit intomainfrom
Open
Optimize CollectionAssert: hoist GetTypeInfo() and avoid redundant eumerations#7536Evangelink wants to merge 1 commit intomainfrom
Evangelink wants to merge 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes a few hot paths in CollectionAssert by avoiding redundant reflection calls and repeated full enumerations of input sequences, improving efficiency without changing assertion semantics.
Changes:
AreEquivalent: reuse the already-computedexpectedCollectionCountinstead of callingexpected.Any()again.AreNotEquivalent: cacheCount()results for both sequences and reuse the cached count for the empty-check.AllItemsAreInstancesOfType: hoistexpectedType.GetTypeInfo()outside the loop to avoid repeating it per element.
You can also share your feedback on Copilot code review. Take the survey.
Youssef1313
reviewed
Mar 12, 2026
…umerations - AllItemsAreInstancesOfType: Move expectedType.GetTypeInfo() outside the loop since it is loop-invariant, avoiding a redundant call per collection element. - AreNotEquivalent: Cache Count() results in local variables instead of calling Count() and then Any() separately, eliminating a third full enumeration of the collection. - AreEquivalent: Replace Any() call with a check against the already-cached count variable.
Evangelink
force-pushed
the
dev/amauryleve/collection-assert
branch
from
89b213b to
efea5ac
Compare
Youssef1313
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AllItemsAreInstancesOfType: Move expectedType.GetTypeInfo() outside the loop since it is loop-invariant, avoiding a redundant call per collection element.
AreNotEquivalent: Cache Count() results in local variables instead of calling Count() and then Any() separately, eliminating a third full enumeration of the collection.
AreEquivalent: Replace Any() call with a check against the already-cached count variable.