Bump dotnet-sdk from 11.0.100-preview.1.26104.118 to 11.0.100-preview.2.26159.112

[dependabot]

Bumps dotnet-sdk from 11.0.100-preview.1.26104.118 to 11.0.100-preview.2.26159.112.

Release notes

Sourced from dotnet-sdk's releases.

.NET 11 Preview 2

Release

Commits

• b8600c8 [release/11.0.1xx-preview2] Source code updates from dotnet/dotnet (#53077)
• b234932 Update dependencies from build 302908
• 5f504a3 Backflow from https://github.com/dotnet/dotnet / e1a0fb2 build 302908
• 64a0291 Add EnableUnsafeAnalyzer to CSC Template
• 0ebb6a1 Update dependencies from build 302391
• 3d89b34 Backflow from https://github.com/dotnet/dotnet / 1db02cb build 302391
• d6def13 Port dotnet/dotnet#4642 (#53194)
• 19ca57b Port dotnet/dotnet#4642
• e9d68d8 [main] Source code updates from dotnet/dotnet (#53001)
• 63ac37e Remove 'Target net11.0' description from web template help approvals
• Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

[Youssef1313]

We are getting now IDE0305 while we didn't set this to warning in any place that I can see. Not sure if it's a Roslyn regression between P1 and P2.

I'm fine fixing the extra diagnostics though.

[Youssef1313]

@akhera99 @ToddGrun Do you know if this is somehow expected? Or if it's a regression in P2?

[CyrusNajmabadi]

What is a repro case?

[Youssef1313]

@CyrusNajmabadi I haven't worked towards getting a minimal repro. So this dependabot branch is all I got. On Preview 1 we didn't get the diagnostic (as we are not enabling it), but on Preview 2 we get a diagnostic.

[Evangelink]

I have seen similar behavior on some other repos, bumping preview 1 to 2 had many IDEXXX analyzers now triggering. Maybe you "just" fixed something.

[CyrusNajmabadi]

Without actually spring the case, it's nearly impossible to answer:

Not sure if it's a Roslyn regression between P1 and P2.

[Evangelink]

src/Adapter/MSTestAdapter.PlatformServices/Helpers/ManagedNameParser.cs(125,48): error IDE0305: (NETCORE_ENGINEERING_TELEMETRY=Build) Collection initialization can be simplified (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0305)

If you just take the code there you have your repro

[CyrusNajmabadi]

That's this line: parameterTypes = types.ToArray();

I don't see any reason to not get the analyzer suggestion there. As an example, you can now write that more simply as: parameterTypes = [.. types];.

Why do you think this is a regression to get this analyzer firing here?

[Evangelink]

The trigger seems correct to me, I think we are more suprised to have new issues showing up by a bump of preview version

[Youssef1313]

I don't see where we are setting the severity of the analyzer to warning. IDExxxx should all be suggestion by default unless explicitly enabled right? That's what surprised me. In addition, there were no changes in that specific analyzer between P1 and P2. Maybe I could be wrong and there is something that sets it to warning, but I don't see it.

[Youssef1313]

Note that in Preview 1, I'm able to see the diagnostic in IDE as a suggestion. So the analyzer was already reporting in this case. It's just that the severity is changing to warning out of sudden.

[Youssef1313]

In P1, this is the globalconfig file that's used:

• D:\a\_work\1\s\.dotnet\sdk\11.0.100-preview.1.26104.118\Sdks\Microsoft.NET.Sdk\analyzers\build\config\analysislevel_10_recommended.globalconfig

In P2, it's:

• D:\a\_work\1\s\.dotnet\sdk\11.0.100-preview.2.26159.112\Sdks\Microsoft.NET.Sdk\codestyle\cs\build\config\analysislevelstyle_recommended.globalconfig

The full list of AnalyzerConfigFiles in P1:

AnalyzerConfigFiles
    D:\a\_work\1\s\.editorconfig
    D:\a\_work\1\s\.packages\polyfill\9.7.3\.editorconfig
    D:\a\_work\1\s\src\.editorconfig
    D:\a\_work\1\s\.globalconfig
    D:\a\_work\1\s\artifacts\obj\MSTestAdapter.PlatformServices\Debug\net9.0\MSTestAdapter.PlatformServices.GeneratedMSBuildEditorConfig.editorconfig
    D:\a\_work\1\s\.dotnet\sdk\11.0.100-preview.1.26104.118\Sdks\Microsoft.NET.Sdk\analyzers\build\config\analysislevel_10_recommended.globalconfig

And the full list of AnalyzerConfigFiles in P2:

AnalyzerConfigFiles
    D:\a\_work\1\s\.editorconfig
    D:\a\_work\1\s\.packages\polyfill\9.7.3\.editorconfig
    D:\a\_work\1\s\src\.editorconfig
    D:\a\_work\1\s\.globalconfig
    D:\a\_work\1\s\.dotnet\sdk\11.0.100-preview.2.26159.112\Sdks\Microsoft.NET.Sdk\codestyle\cs\build\config\analysislevelstyle_recommended.globalconfig
    D:\a\_work\1\s\artifacts\obj\MSTestAdapter.PlatformServices\Debug\net9.0\MSTestAdapter.PlatformServices.GeneratedMSBuildEditorConfig.editorconfig

Interestingly, the one in P1 is only about CAxxxx rules, and the one in P2 is only about IDExxxx rules.

So it's not only about IDExxxx rules now being enabled as warning by default out of sudden (which may or may not be expected - I'll need to dig further to understand). But it seems to me like now CAxxxx rules that were enabled are warnings might no longer be enabled.

The main change I can see is the bump of _LatestAnalysisLevel from 9.0 to 10.0. I'm also not sure if _LatestAnalysisLevel is supposed to actually be 11 during .NET 11 previews?

Adding @baronfel as well.

[Youssef1313]

In P2, NetAnalyzers (CAxxxx) is resolving _GlobalAnalyzerConfigFileName_MicrosoftCodeAnalysisNetAnalyzers to analysislevel_12_recommended.globalconfig (which does not exist?)

So that's why CAxxxx are no longer enabled. Note that the generation of the globalconfig files relies on the release numbers in AnalyzerReleases.Shipped.md AFAIK.

I haven't yet tried to dig into why IDExxxx are now enabled and whether that's expected. In the process of doing that.

[Youssef1313]

EffectiveAnalysisLevel between P1 and P2 jumped from 10 to 12 (we set AnalysisLevel to preview - so I think 12 is expected). The target AddGlobalAnalyzerConfigForPackage_MicrosoftCodeAnalysisCSharpCodeStyle adds editorconfig for IDExxxx rules based on this condition:

    <ItemGroup Condition="Exists('$(_GlobalAnalyzerConfigFile_MicrosoftCodeAnalysisCSharpCodeStyle)') and
                           ('$(AnalysisLevelStyle)' != '$(AnalysisLevel)' or '$(AnalysisModeStyle)' != '$(AnalysisMode)' or ('$(EffectiveAnalysisLevelStyle)' != '' and $([MSBuild]::VersionGreaterThanOrEquals('$(EffectiveAnalysisLevelStyle)', '11.0'))))">
      <EditorConfigFiles Include="$(_GlobalAnalyzerConfigFile_MicrosoftCodeAnalysisCSharpCodeStyle)" />
    </ItemGroup>

I cannot make sense of most parts of the condition, but the important part, I think, is the >= 11 check.

I think there are two things here:

• CAxxxx no longer working as expected. This looks like a bug to me.
• More IDExxxx are now enabled. This looks like an unintentional change that makes AnalysisLevel affecting IDExxx analyzers. The documentation mentions it only for CAxxxx. I think it should be documented as a breaking change that AnalysisLevel now impacts also CodeStyle analyzers. Also, is it documented somewhere what IDExxxx analyzers are enabled in default, minimum, and recommended analysis modes? For example, IDE0004 is not enabled in recommended, but IDE0005 is. Is that documented somewhere without digging into the globalconfigs inside the SDK installation?

I opened:

• .NET 11 Preview 2: AnalysisLevel preview is not enabling any CAxxxx rules dotnet/sdk#53408 for the CAxxxx part.
• .NET 11 Preview 2 breaking change: AnalysisLevel now affects CodeStyle (IDExxxx) analyzers dotnet/sdk#53409 for the IDExxxx part.