Skip to content

Fix DBX JSON schema#381

Merged
apop5 merged 3 commits into
microsoft:mainfrom
cjee21:json-schema
Apr 16, 2026
Merged

Fix DBX JSON schema#381
apop5 merged 3 commits into
microsoft:mainfrom
cjee21:json-schema

Conversation

@cjee21
Copy link
Copy Markdown
Contributor

@cjee21 cjee21 commented Apr 2, 2026

Description

PreSignedObjects\DBX\HashesJsonSchema.json does not accurately describe PreSignedObjects\DBX\dbx_info_msft_latest.json and fails validation. This PR fixes the schema to accurately describe the JSON and enables it to pass validation. The schema is also updated to 2020-12 and format checking is enabled in the validate_schema Python script to validate the format of dates.

Also added DBX JSON schema validation to the CI to ensure both HashesJsonSchema.json and dbx_info_msft_latest.json will remain in sync in the future.

How This Was Tested

>python -m pip install jsonschema[format]
>python scripts\validate_schema.py PreSignedObjects\DBX\dbx_info_msft_latest.json PreSignedObjects\DBX\HashesJsonSchema.json
INFO:root:JSON data is valid against the schema.
INFO:root:JSON data is valid against the schema.

Integration Instructions

N/A

@cjee21
Copy link
Copy Markdown
Contributor Author

cjee21 commented Apr 2, 2026

@microsoft-github-policy-service agree

@Flickdm
Copy link
Copy Markdown
Member

Flickdm commented Apr 2, 2026

@cjee21 can you fix the ruff checks?

@cjee21
Copy link
Copy Markdown
Contributor Author

cjee21 commented Apr 3, 2026

@cjee21 can you fix the ruff checks?

Done. Added JSON schema validation to the CI as well.

@Flickdm Flickdm enabled auto-merge (rebase) April 16, 2026 17:01
auto-merge was automatically disabled April 16, 2026 17:58

Rebase failed

@apop5 apop5 merged commit 32bf3df into microsoft:main Apr 16, 2026
3 checks passed
@cjee21 cjee21 deleted the json-schema branch April 17, 2026 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants