[rush-azure-storage-build-cache-plugin] Add custom endpoint support via storageEndpoint#5664
Open
ryceg wants to merge 2 commits intomicrosoft:mainfrom
Open
[rush-azure-storage-build-cache-plugin] Add custom endpoint support via storageEndpoint#5664ryceg wants to merge 2 commits intomicrosoft:mainfrom
ryceg wants to merge 2 commits intomicrosoft:mainfrom
Conversation
|
@ryceg please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Azure Blob Storage build cache plugin hardcodes the endpoint URL to
https://<account>.blob.core.windows.net/, making it impossible to use with Azurite, private endpoints, or storage emulators. This PR adds an optionalstorageEndpointconfiguration property that overrides the default, bringing the Azure plugin to parity with the S3 plugin's existing s3Endpoint support.Details
Added a new optional storageEndpoint property that flows through all layers:
azure-blob-storage-config.schema.json): New storageEndpoint string property with uri formatIAzureStorageAuthenticationOptions): New optional storageEndpoint fieldAzureStorageAuthentication): Uses storageEndpoint when provided (with trailing slash normalization), falls back to the existing default URLRushAzureStorageBuildCachePlugin): Passes storageEndpoint from config JSON through to the providerThe S3 plugin already supports this pattern via
s3Endpointin AmazonS3BuildCacheProvider.How it was tested
Impacted documentation