Update rust to 1.93.0, and upgrade rust dependencies#3020
Open
joao-boechat wants to merge 9 commits intomainfrom
Open
Update rust to 1.93.0, and upgrade rust dependencies#3020joao-boechat wants to merge 9 commits intomainfrom
joao-boechat wants to merge 9 commits intomainfrom
Conversation
billti
reviewed
Mar 17, 2026
minestarks
approved these changes
Mar 17, 2026
minestarks
reviewed
Mar 17, 2026
| //! For example, a rule might say that if a statement is an expression, it must | ||
| //! return `Unit`. The inferrer would then be used to get the inferred type out of | ||
| //! the expression, giving us a type id, which we can then constrain to `Unit`. | ||
| #![allow(unused_assignments)] |
Member
There was a problem hiding this comment.
Actually - can we put these on the Error structs that actually trigger the warnings, instead of making them module-level? It sounds like this is only an issue for miette error structs, so we can be more specific with the suppression.
Contributor
Author
There was a problem hiding this comment.
I originally tried doing that, but for some reason the suppression wasn't really working. Let me try it again
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes:
miette to 7.6
pyo3 to 0.28
ndarray to 0.17
rust to 1.93