Skip to content

Update rust to 1.93.0, and upgrade rust dependencies#3020

Open
joao-boechat wants to merge 9 commits intomainfrom
joaoboechat/update-rust-dependencies
Open

Update rust to 1.93.0, and upgrade rust dependencies#3020
joao-boechat wants to merge 9 commits intomainfrom
joaoboechat/update-rust-dependencies

Conversation

@joao-boechat
Copy link
Contributor

@joao-boechat joao-boechat commented Mar 16, 2026

Notes:

miette to 7.6

  • Due to some line wrapping updates in the package (lines can now hold more characters), a few tests broke, so I had to update the expected values.
  • The new version introduces a false-positive warning.. A workaround was applied, allowing unused variables, but this needs to be removed once the issue is fixed.

pyo3 to 0.28

  • The FromPyObject implementation for #[pyclass] types that implement Clone was default and now is opt-in. So, I simply added “(from_py_object)” to those types to opt-in for that implementation.

ndarray to 0.17

  • First, I had to update quantum-sparse-sim and then change the commit hash being pointed at.

rust to 1.93

  • Had to deal with some linting enforcements by clippy

@joao-boechat joao-boechat marked this pull request as ready for review March 17, 2026 18:13
@joao-boechat joao-boechat changed the title Joaoboechat/update rust dependencies Update rust to 1.93.0, and upgrade rust dependencies Mar 17, 2026
@joao-boechat joao-boechat enabled auto-merge March 17, 2026 19:52
@joao-boechat joao-boechat requested a review from billti March 17, 2026 21:23
@joao-boechat joao-boechat added this pull request to the merge queue Mar 17, 2026
@joao-boechat joao-boechat removed this pull request from the merge queue due to a manual request Mar 17, 2026
//! For example, a rule might say that if a statement is an expression, it must
//! return `Unit`. The inferrer would then be used to get the inferred type out of
//! the expression, giving us a type id, which we can then constrain to `Unit`.
#![allow(unused_assignments)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually - can we put these on the Error structs that actually trigger the warnings, instead of making them module-level? It sounds like this is only an issue for miette error structs, so we can be more specific with the suppression.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I originally tried doing that, but for some reason the suppression wasn't really working. Let me try it again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants