Skip to content

netvsp: Set deadline on disconnecting endpoints#2991

Draft
ben-zen wants to merge 4 commits intomicrosoft:mainfrom
ben-zen:netvsp-detach-timeout
Draft

netvsp: Set deadline on disconnecting endpoints#2991
ben-zen wants to merge 4 commits intomicrosoft:mainfrom
ben-zen:netvsp-detach-timeout

Conversation

@ben-zen
Copy link

@ben-zen ben-zen commented Mar 13, 2026

Some nodes fail to disconnect the VTL2 VF for the MANA NIC; when these failures occur, recovery takes too long for servicing and raises a fault.

The nodes which reach this state currently do so silently; this will highlight other abnormalities in their operation for further investigation, while still allowing the node to progress in servicing.

@ben-zen ben-zen requested a review from a team as a code owner March 13, 2026 21:58
Copilot AI review requested due to automatic review settings March 13, 2026 21:58
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts NetVSP/MANA VF teardown behavior to avoid long stalls when endpoints fail to disconnect, improving servicing/recovery robustness and surfacing abnormal states via logging.

Changes:

  • Add a warning when the DisconnectableEndpoint update receiver is disconnected.
  • Add a 10s deadline to disconnecting all endpoints in netvsp so teardown can proceed even if disconnect hangs.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
vm/devices/net/net_backend/src/lib.rs Adds a warning when the update channel disconnects while waiting for endpoint actions.
openhcl/underhill_core/src/emuplat/netvsp.rs Wraps endpoint disconnect-all in a timeout via mesh::CancelContext to prevent long servicing delays.

You can also share your feedback on Copilot code review. Take the survey.

@ben-zen ben-zen marked this pull request as draft March 13, 2026 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants