netvsp: Set deadline on disconnecting endpoints#2991
Draft
ben-zen wants to merge 4 commits intomicrosoft:mainfrom
Draft
netvsp: Set deadline on disconnecting endpoints#2991ben-zen wants to merge 4 commits intomicrosoft:mainfrom
ben-zen wants to merge 4 commits intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts NetVSP/MANA VF teardown behavior to avoid long stalls when endpoints fail to disconnect, improving servicing/recovery robustness and surfacing abnormal states via logging.
Changes:
- Add a warning when the
DisconnectableEndpointupdate receiver is disconnected. - Add a 10s deadline to disconnecting all endpoints in
netvspso teardown can proceed even if disconnect hangs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| vm/devices/net/net_backend/src/lib.rs | Adds a warning when the update channel disconnects while waiting for endpoint actions. |
| openhcl/underhill_core/src/emuplat/netvsp.rs | Wraps endpoint disconnect-all in a timeout via mesh::CancelContext to prevent long servicing delays. |
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some nodes fail to disconnect the VTL2 VF for the MANA NIC; when these failures occur, recovery takes too long for servicing and raises a fault.
The nodes which reach this state currently do so silently; this will highlight other abnormalities in their operation for further investigation, while still allowing the node to progress in servicing.