Enhance setup_dbs.py with mssql-tools version check#1581
Merged
Conversation
jahnvi480
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves compatibility with newer versions of
mssql-tools(version 18 and above) by detecting the installed version and conditionally adding encryption-related flags tosqlcmdandbcpcommands. This ensures that database setup scripts work correctly with servers that do not have valid TLS certificates, especially when using self-signed certificates.Compatibility improvements for mssql-tools v18+:
_is_mssqltools_v18()to detect ifmssql-toolsversion 18 or higher is installed, which enforces mandatory encryption by default._encrypt_opt_sqlcmdand_encrypt_opt_bcpto append appropriate encryption flags (-Yo -Cforsqlcmd,-Yo -uforbcp) only when required by the tool version.Command construction updates:
bcpcommand inexecuteBulkCopyto include encryption flags when necessary, ensuring bulk copy operations work with self-signed certificates.setupAEto append the correct encryption flags forsqlcmd, improving reliability with ODBC 18 and above encryption.