Skip to content

feat: Add Tooltip for necessary icons#68

Open
NirajC-Microsoft wants to merge 1 commit intodevfrom
psl-addToolTip1
Open

feat: Add Tooltip for necessary icons#68
NirajC-Microsoft wants to merge 1 commit intodevfrom
psl-addToolTip1

Conversation

@NirajC-Microsoft
Copy link
Contributor

Purpose

This pull request focuses on improving accessibility and usability by adding descriptive title attributes to various interactive elements, as well as making minor import order adjustments for consistency. These changes help users—especially those relying on assistive technologies—better understand the purpose of buttons and icons in the UI.

Accessibility improvements:

  • Added title="Shopping Cart" to the cart button in CartDrawer for clearer identification of its purpose.
  • Added title="Close" to the close button in PanelRightToolbar to provide an accessible label for screen readers and tooltips.
  • Added title="Close" to the close button in SheetContent to enhance accessibility and user experience.

Code organization and consistency:

  • Reordered imports in PanelRightToolbar.tsx and sheet.tsx for consistency and adherence to best practices. [1] [2]
  • Reformatted export statements in sheet.tsx for improved readability and maintainability.

Does this introduce a breaking change?

  • Yes
  • No

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant