Skip to content

perf: update virtual machine size to Standard_D2s_v5#136

Open
Ayaz-Microsoft wants to merge 4 commits intodevfrom
vm-upgrade
Open

perf: update virtual machine size to Standard_D2s_v5#136
Ayaz-Microsoft wants to merge 4 commits intodevfrom
vm-upgrade

Conversation

@Ayaz-Microsoft
Copy link

…ormance

Purpose

  • ...update virtual machine size to Standard_D2s_v5 for improved perormance

Does this introduce a breaking change?

  • Yes
  • No

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the infrastructure templates to use a newer VM SKU (Standard_D2s_v5) intended to improve performance for the deployed virtual machine/jump-box.

Changes:

  • Update virtualMachineSize from Standard_D2s_v3 to Standard_D2s_v5 in both infra/main.bicep and infra/main_custom.bicep.
  • Update VM size guidance comments in infra/modules/virtualNetwork.bicep to include Standard_D2s_v5 as the recommended option.
  • Regenerate/update infra/main.json to reflect the VM size change (but it also includes additional unrelated diffs that need to be addressed).

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 8 comments.

File Description
infra/modules/virtualNetwork.bicep Updates VM SKU guidance comments to include/endorse Standard_D2s_v5.
infra/main_custom.bicep Switches VM size variable to Standard_D2s_v5.
infra/main.bicep Switches VM size variable to Standard_D2s_v5.
infra/main.json Updates compiled template VM size, but also includes unrelated generator/version and scope expression changes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the jumpbox VM sizing defaults in the infrastructure templates to use Standard_D2s_v5 and introduces a configurable vmSize parameter, with accompanying parameter-file and documentation updates to support overrides.

Changes:

  • Add vmSize parameter (default Standard_D2s_v5) and wire it into the jumpbox VM deployment in main.bicep and main_custom.bicep.
  • Add vmSize support to the WAF parameters file for azd-driven deployments.
  • Update documentation/troubleshooting guidance to reflect the new default and override mechanism.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
infra/modules/virtualNetwork.bicep Updates VM size guidance comments to include Standard_D2s_v5 as recommended.
infra/main.bicep Introduces vmSize parameter and uses it for jumpbox VM size.
infra/main_custom.bicep Mirrors vmSize parameterization for the custom template variant.
infra/main.waf.parameters.json Adds vmSize parameter binding to ${AZURE_ENV_VM_SIZE} for WAF deployments.
infra/main.json Regenerated ARM template reflecting vmSize and updated VM size expression.
documents/TroubleShootingSteps.md Expands SkuNotAvailable guidance to mention the new default and override option.
documents/CustomizingAzdParameters.md Documents AZURE_ENV_VM_SIZE as an overridable azd parameter.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants