Open
Conversation
- Updated parameter references in main.parameters.json and main.waf.parameters.json to use consistent naming conventions. - Changed API versions for Cognitive Services and Container Instances in Bicep modules to the latest preview versions. - Enhanced role assignment module to reference updated API versions for existing AI Services and Projects. - Modified web-sites.bicep to include telemetry options and updated API versions, ensuring compatibility with the latest Azure features. - Improved post_deploy.py script to fetch deployment outputs from Azure, allowing for dynamic configuration based on existing resources.
…es and AVMPostDeploymentGuid
This reverts commit bef888a.
chore: main to dev downmerge
fix: code quality
feat: improve Application Insights logging and telemetry handling
fix: Updated azure.yaml file to exclude the 1.23.9 azd version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces several improvements and refactors across the infrastructure, documentation, and environment configuration for the Content Generation solution accelerator. The main focus is on standardizing parameter names, updating module versions for improved reliability and features, and clarifying documentation for post-deployment and technical guidance. The most important changes are grouped below:
Parameter and Environment Variable Standardization:
docs/CustomizingAzdParameters.md,.env.sample,docs/TECHNICAL_GUIDE.md). This ensures consistent naming across deployment, configuration, and code. [1] [2] [3] [4]Infrastructure Module and Resource Updates:
infra/main.bicep). [1] [2] [3] [4] [5]hostingModevalue to'Default'for clarity and correctness (infra/main.bicep).2025-09-01for future compatibility (infra/main.bicep).Resource Tagging and Telemetry Improvements:
infra/main.bicep). [1] [2]enableTelemetryparameter propagation to more modules, clarifying its scope and improving telemetry control (infra/main.bicep). [1] [2]Documentation Enhancements:
docs/AVMPostDeploymentGuide.md) detailing manual post-deployment steps, prerequisites, and verification checks for AVM-based deployments.docs/TECHNICAL_GUIDE.md).Minor Fixes and Improvements:
acrNameparameter optional and clarified telemetry parameter descriptions for improved user experience (infra/main.bicep).infra/main.bicep).infra/main.bicep).These changes collectively improve deployment reliability, configuration consistency, and user guidance for the solution accelerator.
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation