feat: Add VM size recommendations for Bastion and Jumpbox subnets#777
feat: Add VM size recommendations for Bastion and Jumpbox subnets#777Yatish-Microsoft wants to merge 9 commits intodevfrom
Conversation
…virtualNetwork.bicep
Yatish-Microsoft
requested review from
Avijit-Microsoft,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft,
aniaroramsft,
malrose07,
nchandhi and
toherman-msft
as code owners
There was a problem hiding this comment.
Pull request overview
This PR updates the infrastructure templates to support (and document) VM administration in private-networking deployments by adding Bastion/Jumpbox-related networking and configuration parameters.
Changes:
- Renames VNet module parameters (
vnetName/vnetLocation/vnetAddressPrefixes→name/location/addressPrefixes) and makes Bastion/Jumpbox subnets always included when the VNet module is deployed. - Adds Azure Bastion Host + a Windows Jumpbox VM deployment (when
enablePrivateNetworkingis enabled), including new parameters for VM size and admin credentials. - Updates WAF parameters and documentation to expose jumpbox configuration via azd environment variables/parameters.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| infra/modules/virtualNetwork.bicep | Renames params and makes Bastion/Jumpbox subnets unconditional within the module. |
| infra/main.bicep | Adds Bastion Host + Jumpbox VM modules and new input params for VM sizing/credentials. |
| infra/main.waf.parameters.json | Adds parameter wiring for jumpbox admin username/password and VM size. |
| docs/CustomizingAzdParameters.md | Documents new/expanded parameters for private networking + jumpbox configuration. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Yatish-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
…n private networking
Yatish-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 6 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@copilot open a new pull request to apply changes based on the comments in this thread |
Yatish-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…omment, and docs clarity
Yatish-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Yatish-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 6 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…virtualNetwork.bicep
Purpose
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information