Add PercentageOfTotalMemory and MaximumBufferSpace tags#60
Open
juliafishler wants to merge 2 commits intomicrosoft:masterfrom
Open
Add PercentageOfTotalMemory and MaximumBufferSpace tags#60juliafishler wants to merge 2 commits intomicrosoft:masterfrom
juliafishler wants to merge 2 commits intomicrosoft:masterfrom
Conversation
The PercentageOfTotalMemory and MaximumBufferSpace tags are required for uploading the wprp file to Feedback hub. I'm adding these tags to the official wprp so that both file locations are identical.
erikpe-msft
reviewed
Oct 18, 2019
erikpe-msft
approved these changes
Oct 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When uploading a wprp file to Feedback Hub the PercentageOfTotalMemory and MaximumBufferSpace tags are required. Adding those tags here allows the two versions of the file to be identical.
How tested:
With wpr.exe
Ran connection, A2dp and HFP scenarios. Validated the the resultant logs files have all of the data that we need.