Update axe-core to 4.11.1 via Deque.AxeCore.Selenium#2026
Open
v-sohmondal wants to merge 7 commits intomainfrom
Open
Update axe-core to 4.11.1 via Deque.AxeCore.Selenium#2026v-sohmondal wants to merge 7 commits intomainfrom
v-sohmondal wants to merge 7 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Migrate the C# Selenium WebDriver sample from the deprecated
Selenium.Axepackage to the official Deque-maintainedDeque.AxeCore.SeleniumandDeque.AxeCore.Commonspackages (v4.11.1).Motivation
Update axe-core to 4.11.1. The
Selenium.Axepackage is deprecated as Deque has officially taken over the .NET bindings. See dequelabs/axe-core-nuget.Context
Migration steps followed from Deque.AxeCore.Selenium - Migrating from Selenium.Axe.
Selenium.Axe4.0.21 withDeque.AxeCore.Commons4.11.1 andDeque.AxeCore.Selenium4.11.1.using Selenium.Axe;withusing Deque.AxeCore.Commons;andusing Deque.AxeCore.Selenium;.AxeResult.Errorwas removed; any errors that would have appeared there are now reported as exceptions.AxeBuilder.Include(string, string)(iframe + element selector) is not supported. Replaced withAxeBuilder.Include(AxeSelector)usingnew AxeSelector(elementSelector, ancestorFrames).Selenium.AxetoDeque.AxeCore.Seleniumand corrected .NET Framework version floor from 4.5+ to 4.7.1+.Pull request checklist
[failing example] ...pass in the PR build, then confirm they fail in the CI build