Revert update that moved back to Arcade 9#10191
Closed
radical wants to merge 1 commit intomicrosoft:mainfrom
Closed
Revert update that moved back to Arcade 9#10191radical wants to merge 1 commit intomicrosoft:mainfrom
radical wants to merge 1 commit intomicrosoft:mainfrom
Conversation
…ld 20250625.4 (microsoft#10100)" This reverts commit e9dfe00.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the repository to use Arcade SDK 10.0.0-beta.25325.3 (and related 10.0.0-beta.25325.3 packages) and adds new build and VMR‐related flags and retry settings in pipeline templates.
- Bumps Arcade, Helix, SharedFramework, BuildTasks and RemoteExecutor to 10.0.0-beta.25325.3 in
global.json,eng/Versions.props, andeng/Version.Details.xml. - Enhances build tooling: introduces
--fromVMRand--buildCheckflags inbuild.sh/build.ps1, updates caching logic intools.sh, and streamlines locating the Arcade logger. - Adds retry settings (
retryCountOnTaskFailure) in several Azure DevOps templates and adjusts cross‐platform rootfs scripts.
Reviewed Changes
Copilot reviewed 49 out of 51 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| global.json | Arcade SDK version bump |
| eng/common/tools.sh | Expanded use_global_nuget_cache condition; added from_vmr |
| eng/common/cross/build-rootfs.sh | Added --skipemulation support and debootstrap tweaks |
| eng/common/core-templates/steps/source-index-stage1-publish.yml | New step template for stage‐1 source indexing |
Comments suppressed due to low confidence (2)
eng/common/cross/build-rootfs.sh:807
- Passing
--allow-unauthenticatedand--allow-insecure-repositoriestoapt-get updatehas no effect and may be rejected. These options should be applied to the subsequentapt-get installcommands instead.
rm -rf "$__RootfsDir"/etc/apt/*.{sources,list} "$__RootfsDir"/etc/apt/sources.list.d
eng/common/core-templates/steps/source-index-stage1-publish.yml:23
- The parameter is declared as
binlogPath(lowercase "b") but referenced here asBinlogPath. Ensure the casing matches the parameter definition to avoid template expansion errors.
- script: $(Agent.TempDirectory)/.source-index/tools/BinLogToSln -i ${{parameters.BinlogPath}} -r $(Build.SourcesDirectory) -n $(Build.Repository.Name) -o .source-index/stage1output
Member
Author
|
Before merging:
|
Member
|
Since this is a revert, I'd assume it is pretty safe to take. Thanks for noticing this. |
joperezr
approved these changes
Jul 2, 2025
Member
Author
👍 Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#10075 upgraded to Arcade 10, but the subscriptions haven't been updated which caused an unintended downgrade to Arcade 9 via #10100 .
Revert "Update dependencies from https://github.com/dotnet/arcade build 20250625.4 (#10100)"
This reverts commit e9dfe00.