Fix flaky CreatePlaceholderTests stderr comparison#1987
Open
tyrielv wants to merge 1 commit into
Open
Conversation
tyrielv
force-pushed
the
tyrielv/fix-placeholder-flaky-test
branch
from
2d0caba to
703d1b2
Compare
Git's "Updating files" progress output on stderr is timing-dependent, causing ErrorsShouldMatch to fail when one repo emits progress and the other does not. Set GIT_PROGRESS_DELAY=3600 on all test git invocations so progress output is never emitted for commands completing under an hour. This eliminates the flake at the source without skipping error validation. Assisted-by: Claude Opus 4.6 Signed-off-by: Tyrie Vella <tyrielv@gmail.com>
tyrielv
force-pushed
the
tyrielv/fix-placeholder-flaky-test
branch
from
703d1b2 to
249b895
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
AllowsPlaceholderCreationWhileGitCommandIsRunningtest fails intermittently becausegit reset --hardproduces non-deterministicUpdating filesprogress output on stderr. When one repo emits progress and the other does not,ErrorsShouldMatchfails.Set
GIT_PROGRESS_DELAY=3600on all test git invocations (inGitProcess.InvokeProcess) so progress output is never emitted for commands completing under an hour. This eliminates the flake at the source without skipping error validation.