Fix folder name extraction in ConnectorPackageValidator script#4110
Open
tomburger wants to merge 1 commit intomicrosoft:devfrom
Open
Fix folder name extraction in ConnectorPackageValidator script#4110tomburger wants to merge 1 commit intomicrosoft:devfrom
tomburger wants to merge 1 commit intomicrosoft:devfrom
Conversation
Contributor
|
Hi @tomburger, Thank you for updating this script file. However, this script is handled by MS, we will update from our end. Kindly close this PR. |
Contributor
Author
|
Hi @vmanoharas, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixing the validation script
ConnectorPackageValidator.ps1, which is failing when used with PowerShell Core on Windows.Details
When getting name of the folder
pkgAssetthe extraction of the name is missing and full path, including drive name is used. That leads to the error.Most likely it used to work with Windows PowerShell, where object returned by
Get-ChildItemresolved itself into just a name of the directory. And now it resolves into the full path. So addingSelect-Objectto explicitly select name only (like it was one on two other occasions in the same script just a few lines above) fixes the problem.See issue #3752 for more details.