Make IFeatureService async end-to-end to eliminate blocking thread-pool calls#51
Closed
Copilot wants to merge 2 commits into
Closed
Make IFeatureService async end-to-end to eliminate blocking thread-pool calls#51Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Co-authored-by: mark-quickel <112185610+mark-quickel@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] WIP Address feedback on multi-environment support
Make IFeatureService async end-to-end to eliminate blocking thread-pool calls
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IFeatureService.IsFeatureEnabledwas blocking onIFeatureManagerSnapshot.IsEnabledAsyncvia.GetAwaiter().GetResult(), risking thread-pool starvation and deadlocks under ASP.NET request contexts.Changes
IFeatureService/FeatureService— Replacedbool IsFeatureEnabledwithTask<bool> IsFeatureEnabledAsync; implementation now returns theTask<bool>directly fromIFeatureManagerSnapshot.IsEnabledAsyncwithout blockingUploadViewComponent/TabbedNavigationViewComponent— Updated all call sites toawait IsFeatureEnabledAsync(both already in async contexts)Index,Completed,Denied,Justification,Review) — ConvertedOnGet()→async Task OnGetAsync()and awaited feature checks🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.