fix: downmerge from main to dev

[Priyanka-Microsoft]

Purpose

• ...
  This pull request enhances the deployment workflow and notification system by introducing explicit tracking and reporting of the cleanup job's status, improving the clarity of email notifications, and simplifying input validation for the notification job. The changes ensure that the cleanup phase is properly handled and its outcome is reflected in notifications, while also making status summaries and configuration details more visible and user-friendly.

Key changes include:

Workflow Orchestration and Cleanup Handling

• Added a new cleanup-deployment job to .github/workflows/deploy-orchestrator.yml, which runs after deployment and e2e tests, and passes its result to the notification job for reporting. The notification job now depends on the cleanup job.
• Removed the previous inline definition of the cleanup job in the notification job and updated the notification job to receive the cleanup result as input.

Notification Job Improvements

• The notification job (job-send-notification.yml) now accepts a cleanup_result input, determines a human-readable cleanup status, and generates a configuration label (e.g., "WAF + EXP") for use in notifications. [1] [2]
• Email notifications have been updated to include a status summary table (Deployment, E2E Tests, Cleanup) and the configuration label, making it easier to see the outcome of each stage at a glance. Subjects and bodies of emails have been reworded for clarity and consistency. [1] [2] [3] [4]

Input Validation Simplification

• Removed the extensive input parameter validation step from the notification job, streamlining the workflow and reducing redundancy.

Input Defaults and Requirements

• Made the e2e_test_result and cleanup_result inputs optional with sensible defaults, improving robustness when these values are not set. [1] [2]

These changes collectively make the deployment process more robust and transparent, especially in reporting the state of resource cleanup and overall pipeline status.

• Workflow Orchestration and Cleanup Handling

  • Added a dedicated cleanup-deployment job to the orchestrator workflow, ensuring cleanup runs after deployment and e2e tests, and feeds its result into the notification process.
  • Updated notification job dependencies and inputs to include cleanup status, removing the previous inline cleanup logic.

• Notification Job Improvements

  • Introduced logic to determine and report cleanup status and configuration labels in email notifications, with a new summary table for each pipeline stage. [1] [2] [3] [4] [5]

• Input Validation and Defaults

  • Removed the verbose input validation step from the notification job, simplifying the workflow.
  • Made e2e_test_result and cleanup_result inputs optional with defaults, increasing resilience to missing data. [1] [2]

Does this introduce a breaking change?

• Yes
• No

Golden Path Validation

• I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

• I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

• ...

Other Information

[Copilot]

Pull request overview

Updates the GitHub Actions deployment orchestration and notification reusable workflow to explicitly track/report cleanup status in notifications, along with a small deployment guide update for azd preflight behavior.

Changes:

• Adds a dedicated cleanup-deployment job to the deployment orchestrator and wires its result into the notification job.
• Enhances the notification workflow to compute cleanup status + configuration label and include a stage summary table in email bodies/subjects.
• Adds an azd configuration note to the deployment guide.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
docs/DeploymentGuide.md	Adds a note/command for disabling azd preflight.
.github/workflows/job-send-notification.yml	Adds cleanup_result input, cleanup/config label computation, and richer email templates.
.github/workflows/deploy-orchestrator.yml	Introduces cleanup-deployment job and passes its job result into the notification workflow.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.