fix: gp bug and Managed identity changes#375
Draft
Shreyas-Microsoft wants to merge 1 commit intomainfrom
Draft
Conversation
Shreyas-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Shreyas-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
|
|
||
| if comms_manager.group_chat.is_complete: | ||
| break | ||
| is_complete = True |
| import sql from "react-syntax-highlighter/dist/cjs/languages/hljs/sql" | ||
| import { useNavigate, useParams } from "react-router-dom" | ||
| import { useState, useEffect, useCallback } from "react" | ||
| import { useState, useEffect, useCallback, useRef } from "react" |
| const [fileId, setFileId] = React.useState<string>(""); | ||
| const [expandedSections, setExpandedSections] = React.useState<string[]>([]); | ||
| const [allFilesCompleted, setAllFilesCompleted] = useState(false); | ||
| const [progressPercentage, setProgressPercentage] = useState(0); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces several improvements and fixes across both the backend and frontend. The main changes include enhanced Azure credential handling for different environments, improved logging configuration for debugging, a fix to the script conversion loop logic, and frontend updates for better progress tracking and error handling.
Backend Improvements
ClientSecretCredentialorAioDefaultAzureCredential, while in production it defaults toAioManagedIdentityCredential, ensuring the correct authentication method is used based onAPP_ENV. [1] [2]DEBUGby default in.env.sampleto facilitate easier debugging during development.convert_script.pynow uses a boolean flag (is_complete) for clearer and more robust completion detection. [1] [2]Frontend Enhancements
progressPercentagestate and improved the loading timeout logic to show an error only if progress is less than 5% after 30 seconds, providing a better user experience during long operations. [1] [2].dockerignoreto excludenode_modules,dist, and.gitfrom frontend Docker builds, reducing image size and build time.Other minor changes include importing additional React hooks and minor refactoring of file loading logic in the modernization page. [1] [2]
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information