Skip to content

fix: toolbox skill invocation and foundry samples path#2389

Merged
anchenyi merged 2 commits into
mainfrom
anchenyi/fix-toolbox
May 26, 2026
Merged

fix: toolbox skill invocation and foundry samples path#2389
anchenyi merged 2 commits into
mainfrom
anchenyi/fix-toolbox

Conversation

@anchenyi
Copy link
Copy Markdown
Collaborator

Description

This PR makes two focused updates to the microsoft-foundry skill:

  1. Updates the skill description so prompts like “add tool to the agent” can trigger the Microsoft Foundry skill and load the relevant Toolbox knowledge. Because the skill description is limited to 1024 characters, the duplicated “prompt optimizer” phrase was removed to keep the description within the limit.

  2. Fixes outdated Toolbox GitHub sample paths so the skill points to the current Foundry hosted-agent Toolbox samples instead of stale/404 paths.

Checklist

  • Tests pass locally (cd tests && npm test)
  • If modifying skill descriptions: verified routing correctness with integration tests (npm run test:skills:integration -- <skill>)
  • If modifying skill USE FOR / DO NOT USE FOR / PREFER OVER clauses: confirmed no routing regressions for competing skills

Related Issues

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 26, 2026

Details# 🔍 Token Analysis Report

@github-copilot-for-azure/scripts@1.0.0 tokens
node --import tsx src/tokens/cli.ts compare --base origin/main --head HEAD --markdown

📊 Token Change Report

Comparing origin/mainHEAD

Summary

Metric Value
📈 Total Change +12 tokens (0%)
Before 5,544 tokens
After 5,556 tokens
Files Changed 1

Changed Files

File Before After Change
plugin/skills/microsoft-foundry/foundry-agent/create/references/use-toolbox-in-hosted-agent.md 1,410 1,422 +12 (+1%)

@github-copilot-for-azure/scripts@1.0.0 tokens
node --import tsx src/tokens/cli.ts check --markdown

📊 Token Limit Check Report

Checked: 665 files
Exceeded: 97 files

⚠️ Files Exceeding Token Limits

File Tokens Limit Over By
.github/skills/analyze-skill-issues/SKILL.md 2109 500 +1609
.github/skills/analyze-test-run/SKILL.md 2471 500 +1971
.github/skills/file-test-bug/SKILL.md 628 500 +128
.github/skills/sensei/README.md 3531 2000 +1531
.github/skills/sensei/SKILL.md 3026 500 +2526
.github/skills/sensei/references/EXAMPLES.md 3701 2000 +1701
.github/skills/sensei/references/LOOP.md 4169 2000 +2169
.github/skills/sensei/references/SCORING.md 4299 2000 +2299
.github/skills/skill-authoring/SKILL.md 839 500 +339
plugin/skills/airunway-aks-setup/SKILL.md 1025 500 +525
plugin/skills/appinsights-instrumentation/SKILL.md 937 500 +437
plugin/skills/azure-ai/SKILL.md 820 500 +320
plugin/skills/azure-aigateway/SKILL.md 1261 500 +761
plugin/skills/azure-aigateway/references/policies.md 2342 2000 +342
plugin/skills/azure-cloud-migrate/SKILL.md 1085 500 +585
plugin/skills/azure-cloud-migrate/references/services/container-apps/cloudrun-deployment-guide.md 2029 2000 +29
plugin/skills/azure-cloud-migrate/references/services/container-apps/deployment-guide.md 2458 2000 +458
plugin/skills/azure-cloud-migrate/references/services/container-apps/fargate-deployment-guide.md 2587 2000 +587
plugin/skills/azure-cloud-migrate/references/services/container-apps/spring-deployment-guide.md 3871 2000 +1871
plugin/skills/azure-cloud-migrate/references/services/functions/lambda-to-functions.md 2600 2000 +600
plugin/skills/azure-cloud-migrate/references/services/functions/runtimes/javascript.md 2181 2000 +181
plugin/skills/azure-compliance/SKILL.md 1188 500 +688
plugin/skills/azure-compute/SKILL.md 1370 500 +870
plugin/skills/azure-compute/workflows/essential-machine-management/references/emm-enable-flow.md 2344 2000 +344
plugin/skills/azure-compute/workflows/vm-recommender/vm-recommender.md 2631 2000 +631
plugin/skills/azure-compute/workflows/vm-troubleshooter/vm-troubleshooter.md 2509 2000 +509
plugin/skills/azure-cost/SKILL.md 1980 500 +1480
plugin/skills/azure-deploy/SKILL.md 1645 500 +1145
plugin/skills/azure-deploy/references/pre-deploy-checklist.md 4692 2000 +2692
plugin/skills/azure-deploy/references/recipes/azd/errors.md 4004 2000 +2004
plugin/skills/azure-deploy/references/troubleshooting.md 2038 2000 +38
plugin/skills/azure-diagnostics/SKILL.md 1423 500 +923
plugin/skills/azure-enterprise-infra-planner/SKILL.md 1002 500 +502
plugin/skills/azure-enterprise-infra-planner/references/constraints/compute-apps.md 2022 2000 +22
plugin/skills/azure-hosted-copilot-sdk/SKILL.md 1332 500 +832
plugin/skills/azure-kubernetes/SKILL.md 2606 500 +2106
plugin/skills/azure-kubernetes/azure-kubernetes-automatic-readiness/SKILL.md 3609 500 +3109
plugin/skills/azure-kusto/SKILL.md 2152 500 +1652
plugin/skills/azure-messaging/SKILL.md 821 500 +321
plugin/skills/azure-prepare/SKILL.md 3375 500 +2875
plugin/skills/azure-prepare/references/aspire.md 4617 2000 +2617
plugin/skills/azure-prepare/references/plan-template.md 2560 2000 +560
plugin/skills/azure-prepare/references/recipes/azd/aspire.md 2275 2000 +275
plugin/skills/azure-prepare/references/recipes/azd/terraform.md 3555 2000 +1555
plugin/skills/azure-prepare/references/research.md 2274 2000 +274
plugin/skills/azure-prepare/references/resources-limits-quotas.md 3322 2000 +1322
plugin/skills/azure-prepare/references/security.md 2147 2000 +147
plugin/skills/azure-prepare/references/services/functions/bicep.md 3043 2000 +1043
plugin/skills/azure-prepare/references/services/functions/templates/recipes/composition.md 2813 2000 +813
plugin/skills/azure-prepare/references/services/functions/terraform.md 3404 2000 +1404
plugin/skills/azure-quotas/SKILL.md 2821 500 +2321
plugin/skills/azure-quotas/references/commands.md 2644 2000 +644
plugin/skills/azure-reliability/SKILL.md 5659 500 +5159
plugin/skills/azure-reliability/references/configure-multi-region.md 4729 2000 +2729
plugin/skills/azure-resource-lookup/SKILL.md 1367 500 +867
plugin/skills/azure-resource-visualizer/SKILL.md 2122 500 +1622
plugin/skills/azure-storage/SKILL.md 1228 500 +728
plugin/skills/azure-upgrade/SKILL.md 1542 500 +1042
plugin/skills/azure-upgrade/references/languages/java/INSTRUCTION.md 2724 2000 +724
plugin/skills/azure-upgrade/references/languages/java/package-specific/com.microsoft.azure.management.md 2215 2000 +215
plugin/skills/azure-upgrade/references/languages/java/templates/PLAN_TEMPLATE.md 2411 2000 +411
plugin/skills/azure-upgrade/references/languages/java/templates/PROGRESS_TEMPLATE.md 2315 2000 +315
plugin/skills/azure-upgrade/references/languages/java/templates/SUMMARY_TEMPLATE.md 2190 2000 +190
plugin/skills/azure-upgrade/references/services/functions/automation.md 3463 2000 +1463
plugin/skills/azure-upgrade/references/services/functions/consumption-to-flex.md 2773 2000 +773
plugin/skills/azure-validate/SKILL.md 950 500 +450
plugin/skills/entra-agent-id/SKILL.md 4001 500 +3501
plugin/skills/entra-app-registration/SKILL.md 2070 500 +1570
plugin/skills/entra-app-registration/references/api-permissions.md 2545 2000 +545
plugin/skills/entra-app-registration/references/cli-commands.md 2211 2000 +211
plugin/skills/entra-app-registration/references/console-app-example.md 2752 2000 +752
plugin/skills/entra-app-registration/references/oauth-flows.md 2375 2000 +375
plugin/skills/microsoft-foundry/SKILL.md 4134 500 +3634
plugin/skills/microsoft-foundry/finetuning/SKILL.md 1375 500 +875
plugin/skills/microsoft-foundry/foundry-agent/create/create-hosted.md 4824 2000 +2824
plugin/skills/microsoft-foundry/foundry-agent/deploy/deploy.md 8432 2000 +6432
plugin/skills/microsoft-foundry/foundry-agent/deploy/references/direct-code-deployment.md 3690 2000 +1690
plugin/skills/microsoft-foundry/foundry-agent/eval-datasets/eval-datasets.md 2846 2000 +846
plugin/skills/microsoft-foundry/foundry-agent/eval-datasets/references/generate-seed-dataset.md 2185 2000 +185
plugin/skills/microsoft-foundry/foundry-agent/eval-datasets/references/trace-to-dataset.md 4325 2000 +2325
plugin/skills/microsoft-foundry/foundry-agent/faos-optimize/faos-optimize.md 3573 2000 +1573
plugin/skills/microsoft-foundry/foundry-agent/invoke/invoke.md 2058 2000 +58
plugin/skills/microsoft-foundry/foundry-agent/observe/observe.md 3585 2000 +1585
plugin/skills/microsoft-foundry/foundry-agent/observe/references/continuous-eval.md 3860 2000 +1860
plugin/skills/microsoft-foundry/foundry-agent/observe/references/evaluate-step.md 2174 2000 +174
plugin/skills/microsoft-foundry/foundry-agent/observe/references/evaluation-suite-generation.md 2663 2000 +663
plugin/skills/microsoft-foundry/foundry-agent/trace/references/kql-templates.md 2701 2000 +701
plugin/skills/microsoft-foundry/models/deploy-model/SKILL.md 1640 500 +1140
plugin/skills/microsoft-foundry/models/deploy-model/capacity/SKILL.md 1739 500 +1239
plugin/skills/microsoft-foundry/models/deploy-model/customize/SKILL.md 2235 500 +1735
plugin/skills/microsoft-foundry/models/deploy-model/customize/references/customize-workflow.md 3335 2000 +1335
plugin/skills/microsoft-foundry/models/deploy-model/preset/SKILL.md 1226 500 +726
plugin/skills/microsoft-foundry/models/deploy-model/preset/references/preset-workflow.md 5534 2000 +3534
plugin/skills/microsoft-foundry/quota/quota.md 2288 2000 +288
plugin/skills/microsoft-foundry/quota/references/capacity-planning.md 2080 2000 +80
plugin/skills/microsoft-foundry/references/agent-metadata-contract.md 3114 2000 +1114
plugin/skills/microsoft-foundry/references/sdk/foundry-sdk-py.md 2162 2000 +162

Consider moving content to references/ subdirectories.


Automated token analysis. See skill authoring guidelines for best practices.

@anchenyi anchenyi marked this pull request as ready for review May 26, 2026 07:46
Copilot AI review requested due to automatic review settings May 26, 2026 07:46
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the microsoft-foundry skill to better route “add tool to agent” style prompts to Foundry/Toolbox guidance, and refreshes the hosted-agent Toolbox sample/documentation links to current foundry-samples locations.

Changes:

  • Expanded the skill’s trigger description to include “add tool to agent” and updated trigger tests/snapshots accordingly.
  • Updated hosted-agent Toolbox reference documentation to point to current Python/C# sample paths and Learn documentation.
  • Added a unit test to lock down the expected Toolbox reference paths and prevent regressions to removed/404 paths.

Reviewed changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/microsoft-foundry/triggers.test.ts Adds a new “add tool” prompt to the trigger test suite.
tests/microsoft-foundry/snapshots/triggers.test.ts.snap Updates trigger keyword snapshots for the new description keyword set.
tests/microsoft-foundry/resource/create/snapshots/triggers.test.ts.snap Updates snapshot for skill description/keywords after description change.
tests/microsoft-foundry/models/deploy/deploy-model/snapshots/triggers.test.ts.snap Updates snapshot for skill description/keywords after description change.
tests/microsoft-foundry/models/deploy/deploy-model-optimal-region/snapshots/triggers.test.ts.snap Updates snapshot for skill description/keywords after description change.
tests/microsoft-foundry/models/deploy/customize-deployment/snapshots/triggers.test.ts.snap Updates snapshot for skill description/keywords after description change.
tests/microsoft-foundry/models/deploy/capacity/snapshots/triggers.test.ts.snap Updates snapshot for skill description/keywords after description change.
tests/microsoft-foundry/foundry-agent/troubleshoot/snapshots/triggers.test.ts.snap Updates snapshot for skill description/keywords after description change.
tests/microsoft-foundry/foundry-agent/trace/snapshots/triggers.test.ts.snap Updates snapshot for skill description/keywords after description change.
tests/microsoft-foundry/foundry-agent/observe/snapshots/triggers.test.ts.snap Updates snapshot for skill description/keywords after description change.
tests/microsoft-foundry/foundry-agent/invoke/snapshots/triggers.test.ts.snap Updates snapshot for skill description/keywords after description change.
tests/microsoft-foundry/foundry-agent/eval-datasets/snapshots/triggers.test.ts.snap Updates snapshot for skill description/keywords after description change.
tests/microsoft-foundry/foundry-agent/deploy/snapshots/triggers.test.ts.snap Updates snapshot for skill description/keywords after description change.
tests/microsoft-foundry/foundry-agent/create/snapshots/triggers.test.ts.snap Updates snapshot for skill description/keywords after description change.
tests/microsoft-foundry/finetuning/snapshots/triggers.test.ts.snap Updates snapshot for skill description/keywords after description change.
tests/microsoft-foundry/models/deploy/deploy-model/snapshots/triggers.test.ts.snap Updates snapshot for skill description/keywords after description change.
tests/microsoft-foundry/foundry-agent/create/toolbox-paths.unit.test.ts Adds unit coverage to assert the expected Toolbox sample/docs links.
plugin/skills/microsoft-foundry/SKILL.md Updates skill description triggers to include “add tool to agent”.
plugin/skills/microsoft-foundry/foundry-agent/create/references/use-toolbox-in-hosted-agent.md Fixes outdated Toolbox sample/doc URLs to current locations.

@anchenyi anchenyi merged commit e266166 into main May 26, 2026
13 checks passed
@anchenyi anchenyi deleted the anchenyi/fix-toolbox branch May 26, 2026 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants