Skip to content

Run comparison integration tests without skills#2183

Open
JasonYeMSFT wants to merge 4 commits into
microsoft:mainfrom
JasonYeMSFT:chuye/comparison-deploy-tests
Open

Run comparison integration tests without skills#2183
JasonYeMSFT wants to merge 4 commits into
microsoft:mainfrom
JasonYeMSFT:chuye/comparison-deploy-tests

Conversation

@JasonYeMSFT
Copy link
Copy Markdown
Member

Description

Extend the integration test workflow to run comparison tests on Sunday. Unlike regular integration tests, these comparison tests don't load any skills. They are intended for comparing the behavior of the agent with/without our skills to help us guage if our skills are helpful and if they may cause the agent to use significantly more tokens.

Currently, the cron job config only runs azure-deploy tests for the comparison tests.

Checklist

  • Tests pass locally (cd tests && npm test)
  • If modifying skill descriptions: verified routing correctness with integration tests (npm run test:skills:integration -- <skill>)
  • If modifying skill USE FOR / DO NOT USE FOR / PREFER OVER clauses: confirmed no routing regressions for competing skills

Related Issues

Copilot AI review requested due to automatic review settings May 6, 2026 22:31
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Extends the integration test workflows to support “comparison” runs that execute without loading skills (via NO_SKILLS), scheduled for Sundays.

Changes:

  • Add NO_SKILLS gating to skip skill assertions and skill-invocation test suites during comparison runs.
  • Add a Sunday schedule entry and propagate a no-skills input/env var through GitHub Actions workflows.
  • Update PR validation logic to exclude the Sunday comparison schedule from “all skills covered” checks.
Show a summary per file
File Description
tests/utils/evaluate.ts Skips softCheckSkill when NO_SKILLS=true.
tests/skills.json Adds a Sunday schedule entry intended for comparison runs.
tests/azure-deploy/integration.test.ts Skips skill-invocation describe block when NO_SKILLS=true.
.github/workflows/test-azure-deploy.yml Adds no-skills input and sets NO_SKILLS env for Jest runs.
.github/workflows/test-all-integration.yml Adds Sunday cron and wires through no-skills resolution and env.
.github/workflows/pr.yml Limits schedule coverage validation to weekday cron entries only.

Copilot's findings

  • Files reviewed: 6/6 changed files
  • Comments generated: 4

Comment thread .github/workflows/test-all-integration.yml Outdated
Comment thread tests/skills.json Outdated
Comment thread .github/workflows/pr.yml Outdated
Comment thread .github/workflows/pr.yml
@JasonYeMSFT JasonYeMSFT self-assigned this May 7, 2026
Copy link
Copy Markdown
Collaborator

@jongio jongio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean separation - dedicated workflow keeps comparison runs from triggering weekday automation. The NO_SKILLS gating is straightforward and doesn't affect normal test runs. LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants