Introduce AKS review skill

[johnbilliris]

Description

Introduce an Azure Kubernetes Review skill

Checklist

• Tests pass locally (cd tests && npm test)
• If modifying skill descriptions: verified routing correctness with integration tests (npm run test:skills:integration -- <skill>)
• If modifying skill USE FOR / DO NOT USE FOR / PREFER OVER clauses: confirmed no routing regressions for competing skills
• Version bumped in skill frontmatter (if skill files changed)

Related Issues

[Copilot]

Pull request overview

Introduces a new azure-kubernetes-review skill under plugin/skills/ to guide an evidence-based AKS posture review and generate a standardized Markdown audit report.

Changes:

• Adds the azure-kubernetes-review skill with an end-to-end workflow and guardrails.
• Adds reference documents (checklist matrix, container checks, diagnostics detector mapping) plus a report template.
• Updates .gitignore to ignore *.crt files.

Reviewed changes

Copilot reviewed 13 out of 14 changed files in this pull request and generated 11 comments.

Show a summary per file

File	Description
plugin/skills/azure-kubernetes-review/SKILL.md	Skill entrypoint, workflow outline, inputs/outputs, guardrails
plugin/skills/azure-kubernetes-review/assets/aks-audit-report-template.md	Report template for audit output
plugin/skills/azure-kubernetes-review/references/aks-checklist-matrix.md	Canonical checklist matrix + validation commands
plugin/skills/azure-kubernetes-review/references/aks-container-best-practices.md	Container-level best-practice checks and scoring rules
plugin/skills/azure-kubernetes-review/references/aks-diagnostics-detectors.md	Diagnostics detector extraction + mapping guidance
plugin/skills/azure-kubernetes-review/references/quality-gates.md	Completeness checks and decision logic
plugin/skills/azure-kubernetes-review/references/workflow-scope-and-checklist.md	Scope definition + checklist loading workflow
plugin/skills/azure-kubernetes-review/references/workflow-diagnostics.md	Diagnostics execution workflow
plugin/skills/azure-kubernetes-review/references/workflow-warning-events.md	Warning event collection + correlation workflow
plugin/skills/azure-kubernetes-review/references/workflow-container-assessment.md	Container assessment workflow
plugin/skills/azure-kubernetes-review/references/workflow-validation-and-findings.md	Validation command execution + findings workflow
plugin/skills/azure-kubernetes-review/references/workflow-report.md	Report generation workflow
.gitignore	Ignores *.crt files

[kvenkatrajan]

Thanks for your contribution! Consider consolidating this with the main azure-kubernetes skill. We are trying to keep the number of skills low and reduce overlap between skills

[jongio]

Solid contribution with deep AKS domain knowledge. The progressive disclosure structure (SKILL.md + 11 reference files) is well-suited for a complex audit workflow.

Main concern - echoing @kvenkatrajan's feedback: the existing azure-kubernetes skill handles Day-0 provisioning while this targets Day-2 audit. There's a reasonable case for separation given the 1200+ lines of audit-specific content, but the repo's direction is to minimize skill count. Consider whether this could be a mode or workflow within the existing skill (e.g., triggered by "review AKS", "audit AKS cluster") with the reference files living alongside the existing skill's references.

Additional items below focus on frontmatter compliance and missing required sections per repo conventions.

[jongio]

[MEDIUM] metadata.author should be Microsoft

Per skill-files.instructions.md, the recommended author value is Microsoft for all skills in this repo.

Suggested change

	author: johnbilliris
	author: Microsoft

[okonech]

Would it make sense to put more of the review description in more deeply nested files so the azure-kubernetes/SKILL.md‎ file can stay below 1k tokens in size?

[jongio]

+1 on this. Numbers: SKILL.md goes from ~2600 tokens (Day-0 only) to ~4000 tokens with the Day-2 section. It's under the 5000-token cap in skill-files.instructions.md, but the "Required Inputs" table, "Review Workflow" numbered list, and "Review Decision Logic" section could all move to a reference file. That'd bring the main file back to ~3000 tokens while keeping the Day-2 description and trigger phrases in the frontmatter and a one-liner link to the detail.

[jongio]

Consolidation into the existing azure-kubernetes skill addresses my previous concerns and @kvenkatrajan's request. All four of my earlier comments (metadata.author, argument-hint, missing Quick Reference, unrelated .gitignore change) are resolved - the separate skill was removed and the .gitignore hunk dropped.

The Day-2 section integrates cleanly alongside the Day-0 content. Progressive disclosure is solid - 10 reference files handle the detail, keeping the workflow steps in SKILL.md as pointers.

One thing worth watching: SKILL.md went from ~2600 to ~4000 tokens. It's under the 5000-token limit from skill-files.instructions.md, but the Day-2 "Required Inputs" table and "Review Decision Logic" subsections could move to a reference file to keep the main file leaner - see @okonech's thread.