Skip to content

Add skills for webpubsub service#2074

Open
zackliu wants to merge 6 commits into
microsoft:mainfrom
zackliu:chenyl/wps-skills
Open

Add skills for webpubsub service#2074
zackliu wants to merge 6 commits into
microsoft:mainfrom
zackliu:chenyl/wps-skills

Conversation

@zackliu
Copy link
Copy Markdown
Member

@zackliu zackliu commented Apr 28, 2026

Description

Add the initial azure-webpubsub skill with focused guidance for webpubsub best practice.

Checklist

  • [x ] Tests pass locally (cd tests && npm test)
  • [x ] If modifying skill descriptions: verified routing correctness with integration tests (npm run test:skills:integration -- <skill>)
  • [x ] If modifying skill USE FOR / DO NOT USE FOR / PREFER OVER clauses: confirmed no routing regressions for competing skills
  • [x ] Version bumped in skill frontmatter (if skill files changed)

Related Issues

Copilot AI review requested due to automatic review settings April 28, 2026 02:43
@zackliu zackliu force-pushed the chenyl/wps-skills branch from 93dbf9f to 5c6e375 Compare April 28, 2026 02:45
Comment thread plugin/skills/azure-webpubsub/references/negotiate-checklist.md
@kvenkatrajan
Copy link
Copy Markdown
Collaborator

Consider consolidating this under azure-messaging with separate reference files for pubsub. Please note if there are troubleshooting workflows consider consolidating those reference files under azure-diagnostics. Here's a reference file - #1986

@zackliu
Copy link
Copy Markdown
Member Author

zackliu commented Apr 29, 2026

@kvenkatrajan Thanks for the suggestion. My concern is that the two skills have very different scopes.

azure-messaging is primarily troubleshooting-oriented today and it's primary for eventhub and servicebus, while the Web PubSub content here is mostly best-practice and design guidance. If we put them into the same skill file, I worry they will interfere with each other during routing and prompt activation, and the mixed intent may reduce answer quality.

I think a cleaner approach is to keep troubleshooting content consolidated where appropriate, but keep Web PubSub best-practice guidance separate.

Copy link
Copy Markdown
Collaborator

@jongio jongio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issues to address:

  • SKILL.md:15-16 - Quick Reference lists 3 MCP tools but the MCP Tools section (line 28-30) only documents one. An agent won't know when to use monitor or resourcehealth for Web PubSub.
  • triggers.test.ts, unit.test.ts - missing trailing newline

Merge conflict in skills.json needs a rebase (main now includes entra-agent-id).

Comment thread plugin/skills/azure-webpubsub/SKILL.md Outdated
Comment thread tests/azure-webpubsub/triggers.test.ts Outdated
Comment thread tests/azure-webpubsub/unit.test.ts Outdated
Comment thread plugin/skills/azure-webpubsub/references/negotiate-checklist.md
@zackliu zackliu force-pushed the chenyl/wps-skills branch from 1ce468a to e47f738 Compare May 4, 2026 03:44
Copy link
Copy Markdown
Collaborator

@jongio jongio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addresses my previous feedback. Merge conflict resolved, MCP tools table is now consistent, Entra ID roles documented per @JialinXin's suggestion. Looks good.

cc @kvenkatrajan for approval

@zackliu
Copy link
Copy Markdown
Member Author

zackliu commented May 8, 2026

@jongio Please help to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants