Skip to content

build: normalize typetest script presence across client release group #27345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jatgarg merged 6 commits into from
May 20, 2026
Merged

build: normalize typetest script presence across client release group #27345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e959499
build: normalize typetest script presence across client release group
jatgarg May 19, 2026
cfe6ccb
build: also disable type tests for fluid-framework and presence-defin…
jatgarg May 19, 2026
ab26979
build: update lockfile after removing typetest -previous deps
jatgarg May 19, 2026
200580f
build: remove stale presence-definitions type-test file
jatgarg May 19, 2026
cda10a2
build: re-enable type tests for presence-definitions with public entr…
jatgarg May 19, 2026
7408c06
build: re-enable type tests for fluid-framework with public entrypoint
jatgarg May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions experimental/dds/sequence-deprecated/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,7 @@
"test:mocha:cjs": "cross-env FLUID_TEST_MODULE_SYSTEM=CJS mocha",
"test:mocha:esm": "mocha",
"test:mocha:verbose": "cross-env FLUID_TEST_VERBOSE=1 npm run test:mocha",
"tsc": "fluid-tsc commonjs --project ./tsconfig.cjs.json && copyfiles -f ../../../common/build/build-common/src/cjs/package.json ./dist",
"typetests:gen": "flub generate typetests --dir . -v"
"tsc": "fluid-tsc commonjs --project ./tsconfig.cjs.json && copyfiles -f ../../../common/build/build-common/src/cjs/package.json ./dist"
},
"c8": {
"all": true,
Expand Down
3 changes: 1 addition & 2 deletions packages/dds/ink/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,7 @@
"test:mocha:cjs": "cross-env FLUID_TEST_MODULE_SYSTEM=CJS mocha",
"test:mocha:esm": "mocha",
"test:mocha:verbose": "cross-env FLUID_TEST_VERBOSE=1 npm run test:mocha",
"tsc": "fluid-tsc commonjs --project ./tsconfig.cjs.json && copyfiles -f ../../../common/build/build-common/src/cjs/package.json ./dist",
"typetests:gen": "flub generate typetests --dir . -v"
"tsc": "fluid-tsc commonjs --project ./tsconfig.cjs.json && copyfiles -f ../../../common/build/build-common/src/cjs/package.json ./dist"
},
"c8": {
"all": true,
Expand Down
3 changes: 1 addition & 2 deletions packages/dds/legacy-dds/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,8 +100,7 @@
"test:mocha:cjs": "cross-env FLUID_TEST_MODULE_SYSTEM=CJS mocha",
"test:mocha:esm": "mocha",
"test:mocha:verbose": "cross-env FLUID_TEST_VERBOSE=1 npm run test:mocha",
"tsc": "fluid-tsc commonjs --project ./tsconfig.cjs.json && copyfiles -f ../../../common/build/build-common/src/cjs/package.json ./dist",
"typetests:gen": "flub generate typetests --dir . -v"
"tsc": "fluid-tsc commonjs --project ./tsconfig.cjs.json && copyfiles -f ../../../common/build/build-common/src/cjs/package.json ./dist"
},
"c8": {
"all": true,
Expand Down
3 changes: 1 addition & 2 deletions packages/framework/attributor/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,7 @@
"test:mocha:cjs": "cross-env FLUID_TEST_MODULE_SYSTEM=CJS mocha",
"test:mocha:esm": "mocha",
"test:mocha:verbose": "cross-env FLUID_TEST_VERBOSE=1 npm run test:mocha",
"tsc": "fluid-tsc commonjs --project ./tsconfig.cjs.json && copyfiles -f ../../../common/build/build-common/src/cjs/package.json ./dist",
"typetests:gen": "flub generate typetests --dir . -v"
"tsc": "fluid-tsc commonjs --project ./tsconfig.cjs.json && copyfiles -f ../../../common/build/build-common/src/cjs/package.json ./dist"
},
"c8": {
"all": true,
Expand Down
3 changes: 1 addition & 2 deletions packages/framework/client-logger/fluid-telemetry/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,7 @@
"test:realsvc": "npm run test:realsvc:tinylicious",
"test:realsvc:tinylicious": "start-server-and-test start:tinylicious:test 7070 test:realsvc:tinylicious:run",
"test:realsvc:tinylicious:run": "npm run test:mocha:end-to-end",
"tsc": "fluid-tsc commonjs --project ./tsconfig.cjs.json && copyfiles -f ../../../../common/build/build-common/src/cjs/package.json ./dist",
"typetests:gen": "flub generate typetests --dir . -v"
"tsc": "fluid-tsc commonjs --project ./tsconfig.cjs.json && copyfiles -f ../../../../common/build/build-common/src/cjs/package.json ./dist"
},
"dependencies": {
"@fluidframework/container-definitions": "workspace:~",
Expand Down
3 changes: 1 addition & 2 deletions packages/framework/dds-interceptions/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,7 @@
"test:mocha:cjs": "cross-env FLUID_TEST_MODULE_SYSTEM=CJS mocha",
"test:mocha:esm": "mocha",
"test:mocha:verbose": "cross-env FLUID_TEST_VERBOSE=1 npm run test:mocha",
"tsc": "fluid-tsc commonjs --project ./tsconfig.cjs.json && copyfiles -f ../../../common/build/build-common/src/cjs/package.json ./dist",
"typetests:gen": "flub generate typetests --dir . -v"
"tsc": "fluid-tsc commonjs --project ./tsconfig.cjs.json && copyfiles -f ../../../common/build/build-common/src/cjs/package.json ./dist"
},
"c8": {
"all": true,
Expand Down
9 changes: 7 additions & 2 deletions packages/framework/fluid-framework/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,9 @@
"build:compile": "fluid-build . --task compile",
"build:docs": "api-extractor run --local",
"build:esnext": "tsc --project ./tsconfig.json",
"build:test": "npm run build:test:esm && npm run build:test:cjs",
"build:test:cjs": "fluid-tsc commonjs --project ./src/test/tsconfig.cjs.json",
"build:test:esm": "tsc --project ./src/test/tsconfig.json",
Comment thread
jatgarg marked this conversation as resolved.
"check:are-the-types-wrong": "attw --pack .",
"check:biome": "biome check .",
"check:exports": "concurrently \"npm:check:exports:*\"",
Expand All @@ -92,7 +95,8 @@
"format:biome": "biome check . --write",
"lint": "fluid-build . --task lint",
"lint:fix": "fluid-build . --task eslint:fix --task format",
"tsc": "fluid-tsc commonjs --project ./tsconfig.cjs.json && copyfiles -f ../../../common/build/build-common/src/cjs/package.json ./dist"
"tsc": "fluid-tsc commonjs --project ./tsconfig.cjs.json && copyfiles -f ../../../common/build/build-common/src/cjs/package.json ./dist",
"typetests:gen": "flub generate typetests --dir . -v"
},
"dependencies": {
"@fluidframework/container-definitions": "workspace:~",
Expand All @@ -119,12 +123,13 @@
"concurrently": "^9.2.1",
"copyfiles": "^2.4.1",
"eslint": "catalog:eslint",
"fluid-framework-previous": "npm:fluid-framework@2.92.0",
"fluid-framework-previous": "npm:fluid-framework@2.101.0",
"jiti": "^2.6.1",
"rimraf": "^6.1.3",
"typescript": "~5.4.5"
},
"typeValidation": {
"entrypoint": "public",
"broken": {}
}
}
12 changes: 12 additions & 0 deletions packages/framework/fluid-framework/src/test/tsconfig.cjs.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{
// This config must be used in a "type": "commonjs" environment. (Use fluid-tsc commonjs.)
"extends": "./tsconfig.json",
"compilerOptions": {
"outDir": "../../dist/test",
},
"references": [
{
"path": "../../tsconfig.cjs.json",
},
],
}
18 changes: 18 additions & 0 deletions packages/framework/fluid-framework/src/test/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
{
"extends": "../../../../../common/build/build-common/tsconfig.test.node16.json",
"compilerOptions": {
"rootDir": "./",
"outDir": "../../lib/test",
"types": [],
"noImplicitAny": true,
"noUnusedLocals": true,
"noImplicitOverride": true,
"exactOptionalPropertyTypes": true,
},
"include": ["./**/*"],
"references": [
{
"path": "../..",
},
],
}
Loading
Loading