Skip to content

Use include-install-pnpm.yml in build-performance-observability.yml#27333

Open
CraigMacomber wants to merge 6 commits into
microsoft:mainfrom
CraigMacomber:useTemplate
Open

Use include-install-pnpm.yml in build-performance-observability.yml#27333
CraigMacomber wants to merge 6 commits into
microsoft:mainfrom
CraigMacomber:useTemplate

Conversation

@CraigMacomber
Copy link
Copy Markdown
Contributor

Description

Use include-install-pnpm.yml in build-performance-observability.yml to deduplicate pnpm setup logic and gain caching.

Reviewer Guidance

The review process is outlined on this wiki page.

Copilot AI review requested due to automatic review settings May 18, 2026 19:16
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 18, 2026

Hi! Thank you for opening this PR. Want me to review it?

Based on the diff (88 lines, 2 files), I've queued these reviewers:

  • Correctness — logic errors, race conditions, lifecycle issues
  • Security — vulnerabilities, secret exposure, injection
  • API Compatibility — breaking changes, release tags, type design
  • Performance — algorithmic regressions, memory leaks
  • Testing — coverage gaps, hollow tests

How this works

  • Adjust the reviewer set by ticking/unticking boxes above. Reviewer toggles alone don't trigger anything.

  • Tick Start review below to dispatch the review fleet.

  • After review finishes, tick Start review again to request another run — it auto-resets after each dispatch.

  • This comment updates as new commits land; your reviewer selections are preserved.

  • Start review

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the build performance observability pipeline to use the shared pnpm installation template, reducing duplicated setup logic and enabling pnpm store caching.

Changes:

  • Replaces inline npm registry authentication and pnpm installation/configuration steps with include-install-pnpm.yml.
  • Passes the checked-out Fluid Framework directory as the template build directory.

@CraigMacomber CraigMacomber marked this pull request as draft May 18, 2026 21:04
@CraigMacomber CraigMacomber marked this pull request as ready for review May 18, 2026 23:34
Comment thread tools/pipelines/templates/include-install-pnpm.yml
echo "Pnpm user config location: $(pnpm config get userconfig)"
pnpm config set store-dir ${{ parameters.pnpmStorePath }}
echo "Pnpm store: ${{ parameters.pnpmStorePath }}"
echo "Primary registry: ${NPM_REGISTRY}"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this log (outputing registry value to pipeline for information purposes) got removed from pipeline logs in the sample run you provided. IMO we should keep it around; which registry we're using is an occasionally helpful diagnostic.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM otherwise though. Ping if you need approval after addressing.

CraigMacomber and others added 2 commits May 19, 2026 13:26
Co-authored-by: Alex Villarreal <716334+alexvy86@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants