Use include-install-pnpm.yml in build-performance-observability.yml#27333
Use include-install-pnpm.yml in build-performance-observability.yml#27333CraigMacomber wants to merge 6 commits into
Conversation
|
Hi! Thank you for opening this PR. Want me to review it? Based on the diff (88 lines, 2 files), I've queued these reviewers:
How this works
|
There was a problem hiding this comment.
Pull request overview
This PR updates the build performance observability pipeline to use the shared pnpm installation template, reducing duplicated setup logic and enabling pnpm store caching.
Changes:
- Replaces inline npm registry authentication and pnpm installation/configuration steps with
include-install-pnpm.yml. - Passes the checked-out Fluid Framework directory as the template build directory.
569e9ca to
69229a7
Compare
| echo "Pnpm user config location: $(pnpm config get userconfig)" | ||
| pnpm config set store-dir ${{ parameters.pnpmStorePath }} | ||
| echo "Pnpm store: ${{ parameters.pnpmStorePath }}" | ||
| echo "Primary registry: ${NPM_REGISTRY}" |
There was a problem hiding this comment.
this log (outputing registry value to pipeline for information purposes) got removed from pipeline logs in the sample run you provided. IMO we should keep it around; which registry we're using is an occasionally helpful diagnostic.
There was a problem hiding this comment.
Change LGTM otherwise though. Ping if you need approval after addressing.
Co-authored-by: Alex Villarreal <716334+alexvy86@users.noreply.github.com>
Description
Use include-install-pnpm.yml in build-performance-observability.yml to deduplicate pnpm setup logic and gain caching.
Reviewer Guidance
The review process is outlined on this wiki page.