-
Notifications
You must be signed in to change notification settings - Fork 576
Update root workspace to pnpm 11 #27307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
CraigMacomber
wants to merge
15
commits into
microsoft:main
Choose a base branch
from
CraigMacomber:pnpm11
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
1674d52
Update root workspace to pnpm 11
CraigMacomber ed9dc4b
Remove pipeline override of workspace-concurrency 0 since we already …
CraigMacomber 59709f2
Recreate npmrc
CraigMacomber 3fc2448
Fix missing npmrc file properly
CraigMacomber 240715f
Disable verifyDepsBeforeRun
CraigMacomber 4c36063
Fix ci:check:are-the-types-wrong
CraigMacomber 371f9c6
Merge branch 'main' into pnpm11
CraigMacomber 14d2f3d
Merge branch 'main' into pnpm11
CraigMacomber b98016a
Fix local module purge error, and bump pnpm version
CraigMacomber f18a1d1
Updte to 11.1.3
CraigMacomber 7ac5c70
Merge branch 'main' of https://github.com/microsoft/FluidFramework in…
CraigMacomber b0c9bfd
Fix color setting, and go back to engines instead of devEngines as de…
CraigMacomber 4c59a44
top level yaml line breaks
CraigMacomber 659a2a6
cleanup overrides a bit
CraigMacomber 7d9e6ca
Merge branch 'main' of https://github.com/microsoft/FluidFramework in…
CraigMacomber File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 changes: 0 additions & 29 deletions
29
packages/test/test-version-utils/compat-workspaces/scripts/only-pnpm.cjs
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,7 +21,7 @@ const message = ` | |
| ╚══════════════════════════════════════════════════════════════════╝ | ||
| `; | ||
|
|
||
| const used_pnpm = process.env.npm_config_user_agent.startsWith(`pnpm`); | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This crashed with pnpm 11 since npm_config_user_agent was undefined. |
||
| const used_pnpm = (process.env.npm_execpath ?? "").includes(`pnpm`); | ||
|
|
||
| if (!used_pnpm) { | ||
| console.error(message); | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add some blank lines above the top-level sections to improve readability?