Skip to content

Add permissions block to changeset workflows#19335

Merged
Abe27342 merged 1 commit into
mainfrom
test/changeset-workflow-permissions
Jan 29, 2024
Merged

Add permissions block to changeset workflows#19335
Abe27342 merged 1 commit into
mainfrom
test/changeset-workflow-permissions

Conversation

@Abe27342
Copy link
Copy Markdown
Contributor

Description

Updates the workflows related to changeset management to include a permissions block.

See github permissions doc here.

@github-actions github-actions Bot added area: build Build related issues base: main PRs targeted against main branch labels Jan 23, 2024
@Abe27342
Copy link
Copy Markdown
Contributor Author

Abe27342 commented Jan 23, 2024

Going to use this PR to validate the flow still works. I'll add links here as I do so to the relevant action runs.

@Abe27342 Abe27342 added the changeset-required PR requires a changeset label Jan 23, 2024
@github-actions github-actions Bot removed the changeset-required PR requires a changeset label Jan 23, 2024
@github-actions
Copy link
Copy Markdown
Contributor

This PR requires a changeset, but none is present. You should add one before you merge. See the documentation in the wiki for more information about changesets and how to create them.

@Abe27342
Copy link
Copy Markdown
Contributor Author

Abe27342 commented Jan 23, 2024

Upon adding changeset required label, workflows succeeded in posting a comment when corresponding PR didn't have a changeset. See above comment. Relevant action runs:

https://github.com/microsoft/FluidFramework/actions/runs/7632044704/job/20791366400?pr=19335
https://github.com/microsoft/FluidFramework/actions/runs/7632057995

Note that the second action isn't actually running the version with restricted permissions; commit it references is from main. After reading the workflow_run doc, I think this can only be tested by checking this change into a fork and verifying it works there. I've done that on this PR in my fork, see corresponding changeset-reporter run here.

@Abe27342 Abe27342 marked this pull request as ready for review January 23, 2024 21:44
@Abe27342 Abe27342 requested a review from a team as a code owner January 23, 2024 21:44
@Abe27342 Abe27342 merged commit 330320b into main Jan 29, 2024
@Abe27342 Abe27342 deleted the test/changeset-workflow-permissions branch January 29, 2024 17:09
alexvy86 pushed a commit to alexvy86/FluidFramework that referenced this pull request Feb 13, 2024
## Description

Updates the workflows related to changeset management to include a
permissions block.

See github permissions doc
[here](https://docs.github.com/en/enterprise-cloud@latest/actions/using-workflows/workflow-syntax-for-github-actions#permissions).

Co-authored-by: Abram Sanderson <absander@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: build Build related issues base: main PRs targeted against main branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants