fix: merging dev to main

[Priyanka-Microsoft]

Purpose

• ...
  This pull request updates the default virtual machine (VM) size for the Jumpbox VM to Standard_D2s_v5 across the deployment templates, documentation, and parameter files. It also improves troubleshooting documentation for SKU availability errors and provides clearer guidance and parameterization for VM sizing.

Jumpbox VM Size Default Update and Documentation Improvements:

Infrastructure and Parameterization

• Changed the default Jumpbox VM size from Standard_DS2_v2 to Standard_D2s_v5 in infra/main.bicep, infra/main.json, and the Jumpbox VM module, ensuring new deployments use a more current and performant VM size. [1] [2] [3] [4]
• Updated the parameterization to allow overriding the VM size through the AZURE_ENV_VM_SIZE environment variable, and reflected this in infra/main.waf.parameters.json and docs/CustomizingAzdParameters.md. [1] [2]
• Updated Bicep and ARM template generator metadata to the latest version. [1] [2] [3]

Documentation and Troubleshooting

• Enhanced the troubleshooting guide for SKU availability errors, specifically referencing the new default (Standard_D2s_v5), providing alternative VM sizes, and giving explicit instructions for overriding the default if unavailable in a region.
• Updated VM sizing recommendations in infra/modules/virtualNetwork.bicep to highlight Standard_D2s_v5 as the recommended option, with notes on previous generation alternatives.

Does this introduce a breaking change?

• Yes
• No

Golden Path Validation

• I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

• I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

• ...

Other Information

[Copilot]

Pull request overview

This PR updates the default Jumpbox VM size to Standard_D2s_v5 across the infrastructure templates and aligns documentation/parameterization to support overriding the VM size via AZURE_ENV_VM_SIZE, along with improved troubleshooting guidance for SKU availability errors.

Changes:

• Updated Jumpbox VM size default from Standard_DS2_v2 to Standard_D2s_v5 in Bicep and generated ARM templates.
• Added vmSize parameter wiring in the WAF parameters file to support override via AZURE_ENV_VM_SIZE.
• Refreshed documentation to include the new default and add SKU availability troubleshooting guidance.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
infra/modules/virtualNetwork.bicep	Updates VM size guidance comments to recommend Standard_D2s_v5 and list alternatives.
infra/main.waf.parameters.json	Adds vmSize parameter sourced from AZURE_ENV_VM_SIZE for WAF deployments.
infra/main.json	Updates generated ARM template metadata and changes vmSize defaults/fallbacks to Standard_D2s_v5.
infra/main.bicep	Changes the default vmSize to Standard_D2s_v5 and updates Jumpbox module parameter defaulting.
docs/TroubleShootingSteps.md	Expands SkuNotAvailable troubleshooting with guidance specific to the new default VM size and override.
docs/CustomizingAzdParameters.md	Documents AZURE_ENV_VM_SIZE and its default value.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.