Skip to content

Improve robustness of Workday Manager scenarios by validating EmployeeName. #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
roohyfatima91 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve robustness of Workday Manager scenarios by validating EmployeeName. #467

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 29 additions & 1 deletion ...oyeeSelfServiceAgent/Workday/ManagerScenarios/WorkdayManagerServiceAnniversary/topic.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,35 @@ beginDialog:
id: conditionGroup_P6QlNE
conditions:
- id: conditionItem_3RSvtM
condition: =!IsBlank(Topic.EmployeeName)
condition: =!IsBlank(Topic.EmployeeName)&&
Lower(Trim(Topic.EmployeeName)) <> Lower(Trim(Global.ESS_UserContext_Employee_Firstname))
&&
Lower(Trim(Topic.EmployeeName)) <> Lower(Trim(Global.ESS_UserContext_Employee_Lastname))
&&
Lower(Trim(Topic.EmployeeName)) <> Lower(Trim(
Concatenate(
Global.ESS_UserContext_Employee_Firstname,
" ",
Global.ESS_UserContext_Employee_Lastname
)
))
&&
Lower(Trim(Topic.EmployeeName)) <> Lower(Trim(
Concatenate(
Global.ESS_UserContext_Employee_Lastname,
" ",
Global.ESS_UserContext_Employee_Firstname
)
))
&&
Lower(Trim(Topic.EmployeeName)) <> Lower(Trim(
Concatenate(
Global.ESS_UserContext_Employee_Lastname,
", ",
Global.ESS_UserContext_Employee_Firstname
)
))
displayName: Check if EmployeeName provided
displayName: Check if EmployeeName provided
actions:
- kind: SetVariable
Expand Down
29 changes: 29 additions & 0 deletions ...yeeSelfServiceAgent/Workday/ManagerScenarios/WorkdayManagersdirect-CompanyCode/topic.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,35 @@ beginDialog:
conditions:
- id: conditionItem_86c1ij
condition: =!IsBlank(Topic.EmployeeName)
&&
Lower(Trim(Topic.EmployeeName)) <> Lower(Trim(Global.ESS_UserContext_Employee_Firstname))
&&
Lower(Trim(Topic.EmployeeName)) <> Lower(Trim(Global.ESS_UserContext_Employee_Lastname))
&&
Lower(Trim(Topic.EmployeeName)) <> Lower(Trim(
Concatenate(
Global.ESS_UserContext_Employee_Firstname,
" ",
Global.ESS_UserContext_Employee_Lastname
)
))
&&
Lower(Trim(Topic.EmployeeName)) <> Lower(Trim(
Concatenate(
Global.ESS_UserContext_Employee_Lastname,
" ",
Global.ESS_UserContext_Employee_Firstname
)
))
&&
Lower(Trim(Topic.EmployeeName)) <> Lower(Trim(
Concatenate(
Global.ESS_UserContext_Employee_Lastname,
", ",
Global.ESS_UserContext_Employee_Firstname
)
))
displayName: Check if EmployeeName provided
displayName: Check if EmployeeName provided
actions:
- kind: SetVariable
Expand Down
29 changes: 28 additions & 1 deletion ...oyeeSelfServiceAgent/Workday/ManagerScenarios/WorkdayManagersdirect-CostCenter/topic.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,34 @@ beginDialog:
id: conditionGroup_eEjEWp
conditions:
- id: conditionItem_yv6Ggl
condition: =!IsBlank(Topic.EmployeeName)
condition: =!IsBlank(Topic.EmployeeName)&&
Lower(Trim(Topic.EmployeeName)) <> Lower(Trim(Global.ESS_UserContext_Employee_Firstname))
&&
Lower(Trim(Topic.EmployeeName)) <> Lower(Trim(Global.ESS_UserContext_Employee_Lastname))
&&
Lower(Trim(Topic.EmployeeName)) <> Lower(Trim(
Concatenate(
Global.ESS_UserContext_Employee_Firstname,
" ",
Global.ESS_UserContext_Employee_Lastname
)
))
&&
Lower(Trim(Topic.EmployeeName)) <> Lower(Trim(
Concatenate(
Global.ESS_UserContext_Employee_Lastname,
" ",
Global.ESS_UserContext_Employee_Firstname
)
))
&&
Lower(Trim(Topic.EmployeeName)) <> Lower(Trim(
Concatenate(
Global.ESS_UserContext_Employee_Lastname,
", ",
Global.ESS_UserContext_Employee_Firstname
)
))
displayName: Check if EmployeeName provided
actions:
- kind: SetVariable
Expand Down
30 changes: 29 additions & 1 deletion ...yeeSelfServiceAgent/Workday/ManagerScenarios/WorkdayManagersdirect-Jobtaxanomy/topic.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,35 @@ beginDialog:
id: conditionGroup_yepfHF
conditions:
- id: conditionItem_86c1ij
condition: =!IsBlank(Topic.EmployeeName)
condition: =!IsBlank(Topic.EmployeeName)&&
Lower(Trim(Topic.EmployeeName)) <> Lower(Trim(Global.ESS_UserContext_Employee_Firstname))
&&
Lower(Trim(Topic.EmployeeName)) <> Lower(Trim(Global.ESS_UserContext_Employee_Lastname))
&&
Lower(Trim(Topic.EmployeeName)) <> Lower(Trim(
Concatenate(
Global.ESS_UserContext_Employee_Firstname,
" ",
Global.ESS_UserContext_Employee_Lastname
)
))
&&
Lower(Trim(Topic.EmployeeName)) <> Lower(Trim(
Concatenate(
Global.ESS_UserContext_Employee_Lastname,
" ",
Global.ESS_UserContext_Employee_Firstname
)
))
&&
Lower(Trim(Topic.EmployeeName)) <> Lower(Trim(
Concatenate(
Global.ESS_UserContext_Employee_Lastname,
", ",
Global.ESS_UserContext_Employee_Firstname
)
))
displayName: Check if EmployeeName provided
displayName: Check if EmployeeName provided
actions:
- kind: SetVariable
Expand Down