[Bug][SubscriptionBilling]Apply customer/vendor "Format Region" when creating document lines#6911
Open
miljance wants to merge 1 commit intomicrosoft:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request enhances the handling of date and number formatting for billing period descriptions in both sales and purchase documents, ensuring that the document's format region is used instead of the operator's region. It also introduces comprehensive automated tests to verify this behavior for both document types.
Improvements to formatting behavior:
codeunit 8060 "Create Billing Documents"to temporarily set the format region to the document's format region (fromSalesHeaderorPurchaseHeader) when generating billing period descriptions, ensuring consistency regardless of the operator's regional settings. The override is cleared immediately after use.Languagecodeunit variable to manage format region overrides.using System.Globalization;to support culture-specific formatting.Automated tests:
RecurringBillingDocsTest.Codeunit.al:Work Item(s)
Fixes #6680