Uptake/rename license configurations#6404
Open
BenPlunk wants to merge 11 commits intomicrosoft:mainfrom
Open
Conversation
Renamed license configurations and updated upgrade code Related work items: #29700
Renamed license configurations and updated upgrade code Related work items: #29700
github-actions
bot
added
AL: System Application
From Fork
darjoo
requested changes
Feb 11, 2026
src/System Application/App/Azure AD Plan/src/PlanUpgrade.Codeunit.al
Outdated
Show resolved
Hide resolved
jobulsin
reviewed
Feb 12, 2026
src/System Application/App/Azure AD Plan/src/PlanInstaller.Codeunit.al
Outdated
Show resolved
Hide resolved
jobulsin
reviewed
Feb 12, 2026
src/System Application/App/Azure AD Plan/src/PlanInstaller.Codeunit.al
Outdated
Show resolved
Hide resolved
jobulsin
reviewed
Feb 12, 2026
stkillen
reviewed
Feb 25, 2026
Contributor
stkillen
left a comment
stkillen
left a comment
There was a problem hiding this comment.
A couple of comments below. Additionally, we need a PR for BaseApp to replace any usages of old functions.
src/System Application/App/Azure AD Plan/src/PlanInstaller.Codeunit.al
Outdated
Show resolved
Hide resolved
Author
New Base app PR to update old references https://github.com/microsoft/BusinessCentralApps/pull/1828 |
WaelAbuSeada
previously approved these changes
Mar 3, 2026
stkillen
requested changes
Mar 3, 2026
Contributor
stkillen
left a comment
stkillen
left a comment
There was a problem hiding this comment.
Looking at Joost's comments earlier, we should match the regular plan names with the new delegated plan names. Added suggestions for the two plans and then we should rename in upgrade as well.
src/System Application/App/Azure AD Plan/src/PlanInstaller.Codeunit.al
Outdated
Show resolved
Hide resolved
src/System Application/App/Azure AD Plan/src/PlanInstaller.Codeunit.al
Outdated
Show resolved
Hide resolved
…ure.com/fenwick/Gold/_git/Yellowstone.BCApps into uptake/rename-license-configurations
stkillen
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Work Item(s)
Fixes #6403
AB#582117