Open
Conversation
Added new Approval APIs and Tests Related work items: microsoft#29223
Contributor
onbuyuka
requested changes
Mar 3, 2026
| { | ||
| Caption = 'Approval Code'; | ||
| } | ||
| field(salespersPurchCode; Rec."Salespers./Purch. Code") |
Contributor
There was a problem hiding this comment.
We do not use abbreviations for field names
|
|
||
| page 30094 "APIV2 - Approval Entries" | ||
| { | ||
| APIGroup = 'auditing'; |
Contributor
There was a problem hiding this comment.
If these are going to be a separate group, then they shouldn't be in APIV2 app. Instead they should get their own app.
| { | ||
| APIGroup = 'auditing'; | ||
| APIPublisher = 'microsoft'; | ||
| APIVersion = 'v2.0'; |
Contributor
There was a problem hiding this comment.
microsoft/auditing is a new API path, why v2.0?
- Either no new path and part of standard APIs (not favorable)
- Or new app (favorable)
Co-authored-by: Onat Buyukakkus <55088871+onbuyuka@users.noreply.github.com>
Co-authored-by: Onat Buyukakkus <55088871+onbuyuka@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added the following APIs:
Read-only API that allows to query Workflow
Read-only API that allows to query (Workflow, User) mappings
Read-only API that allows to query (Workflow, User, action) history
Depends on Objects in Base App PR https://github.com/microsoft/BusinessCentralApps/pull/1733
Work Item(s)
Fixes #29777
AB#613827