Skip to content

chore: use GitHub Action#21

Open
ldez wants to merge 3 commits intomibk:masterfrom
golangci:feat/gha
Open

chore: use GitHub Action#21
ldez wants to merge 3 commits intomibk:masterfrom
golangci:feat/gha

Conversation

@ldez
Copy link
Copy Markdown

@ldez ldez commented Mar 20, 2024

Replace Travis with GitHub Action.

@mibk
Copy link
Copy Markdown
Owner

mibk commented Apr 30, 2024

Thank you for your contributions, but I'm not sure I can merge this as is.

  • “chore: update Go version” seems fine as it is. I'd be happy to merge this.
  • “chore: add .gitignore” appears unnecessary. The .idea directory can be added to the global .gitignore file instead.
  • “chore: use GitHub Actions” I don't have experience with GitHub Actions, and this seems a bit too complex for a tool that's essentially in maintenance mode. Including a Makefile is not necessary at all.

@ldez
Copy link
Copy Markdown
Author

ldez commented May 4, 2024

“chore: use GitHub Actions” I don't have experience with GitHub Actions, and this seems a bit too complex for a tool that's essentially in maintenance mode. Including a Makefile is not necessary at all.

Currently, you are using Travis but Travis is dead, which means you have no CI.
Even if the project is in maintenance mode, I think a CI is always useful.

The Makefile is just a way to document the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants