fix: cache project tag lookups to avoid redundant XML parsing#52
Open
mfogliatto wants to merge 2 commits into
Open
fix: cache project tag lookups to avoid redundant XML parsing#52mfogliatto wants to merge 2 commits into
mfogliatto wants to merge 2 commits into
Conversation
- Replace target-typed new() with explicit ConcurrentDictionary<string, string>() - Rename _cache to cache (SA1309) - Add this. prefix to field access (SA1101) - Ensure space after new keyword (SA1000)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Caches the result of
ProjectTagProvider.GetProjectTag()using aConcurrentDictionary, so each project file is read and parsed at most once per analyzer lifetime instead of once per rule × reference combination.Changes
ConcurrentDictionary<string, string>cache toProjectTagProvider_cache.GetOrAdd()callSystem.Collections.Concurrentusing directiveTesting
No dotnet SDK available in CI environment; change is minimal and mechanical. Existing tests should pass unchanged since behavior is identical (same inputs → same outputs, just cached).
Fixes #51