Fix: allow newer dukpy versions to be used#85
Fix: allow newer dukpy versions to be used#85peircej wants to merge 1 commit intometapensiero:masterfrom
Conversation
Newer Python installs don't have wheels for old dukpy (<0.2.3) and it needs compiling so they generally fail to install metapensiero. The issue that was causing metapensiero tests to fail was just a call to `this.console = {log: print}` which it seems we can live without. Just removing means we get back up and running
See https://gitlab.com/metapensiero/metapensiero.pj/-/issues/38
|
@azazel75 I submitted the same request to gitlab.com as I'm not sure which is your preferred repo. Would be great if you could pull this in - making it hard for my users to install metapensiero right now |
|
You can see the test suite pass here |
|
Hi @peircej, I can publish a new release with your PR this evening or tomorrow |
|
I was a bit naive on this, I'm sorry... the tests passed just because the test suite used python versions that are now in EOL ("python37" "python38" "python39") I've updated the environment to use current python versions 3.10, 3.11, 3.12, 3.13... but the testing explodes... for one the library "Meta" which is a dependency has not been updated recently and this causes various test failures... I don't know still how to proceed: the choices are to open a PR to update the Meta's package, or move the code into metapensiero.pj and remove the dependency... in either case it's much more effort to fix the things... |
|
Oh no! How annoying. I think I ran the tests on 3.10 (macos) and it was fine but I'll look again |
|
I just tried using py3.10 on a local machine and the tests passed fine. So could you maybe just limit to py3.10, which is not EOL but doesn't have the breaking changes of later versions? For our project, I'll certainly make it a priority to move away from metapensiero though anticipating it not being further maintained. Thanks for your help along the way 😁 🙏 Test detailsWith a py3.10 venv, pytest gave me: With py3.11 venv I get |
Newer Python installs don't have wheels for old dukpy (<0.2.3) and it needs compiling so they generally fail to install metapensiero. The issue that was causing metapensiero tests to fail was just a call to
this.console = {log: print}which it seems we can live without. Just removing means we get back up and runningSee https://gitlab.com/metapensiero/metapensiero.pj/-/issues/38