Migrate to valkey-go#184
Open
majst01 wants to merge 28 commits into
Open
Conversation
majst01
commented
Apr 22, 2026
Sven-Ric
reviewed
May 19, 2026
Sven-Ric
reviewed
May 19, 2026
Co-authored-by: Sven-Ric <sven.richter@x-cellent.com>
Co-authored-by: Sven-Ric <sven.richter@x-cellent.com>
valkey does not autodect a "/" prefix as a unix socket and expects "unix://". Observed Error: unable to create valkey client: dial tcp: address /var/run/redis/redis.sock: missing port in address"}
Replaced the compat HSET with native one. Original behaviour from
compat.HSet
func (c *Compat) HSet(ctx context.Context, key string, values ...any)
*IntCmd {
partial := c.client.B().Hset().Key(key).FieldValue()
args := argsToSlice(values)
for i := 0; i < len(args); i += 2 {
partial = partial.FieldValue(args[i], args[i+1])
}
cmd := partial.Build()
resp := c.client.Do(ctx, cmd)
return newIntCmd(resp)
}
Original does not guard against nil val.
mwennrich
approved these changes
May 21, 2026
Sven-Ric
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
redis-go does not really support timeout for calls, but valkey-go does.
There are some redis related tests, but sadly based on mocks, should be migrated to in-process miniredis to get a better test coverage.