Add pyre-strict to mslk/mslk/conv/_meta.py#346
Open
jwfromm wants to merge 1 commit into
Open
Conversation
Summary: Enables strict Pyre type checking for `fbcode/mslk/mslk/conv/_meta.py` by adding the `# pyre-strict` directive. The file contains Meta (shape inference) implementations for Conv ops that were previously registered in C++. The code already fully satisfies strict mode requirements with no type errors, so only the directive annotation was needed. This improves code quality by opting the module into stricter type safety guarantees going forward. Differential Revision: D105271984
|
@jwfromm has exported this pull request. If you are a Meta employee, you can view the originating Diff in D105271984. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Enables strict Pyre type checking for
fbcode/mslk/mslk/conv/_meta.pyby adding the# pyre-strictdirective. The file contains Meta (shape inference) implementations for Conv ops that were previously registered in C++. The code already fully satisfies strict mode requirements with no type errors, so only the directive annotation was needed. This improves code quality by opting the module into stricter type safety guarantees going forward.Differential Revision: D105271984