Fix three failing CI jobs: format, Fedora hook, ASAN#1
Merged
Conversation
- Format 9 Dart source files to pass dart format --set-exit-if-changed - hook/build.dart: replace 'which' with 'sh -c command -v' to work on Fedora where 'which' is not installed by default - .github/workflows/ci.yml: add libclang-rt-19-dev to ASAN job to provide missing ASAN runtime libraries Agent-Logs-Url: https://github.com/meta-flutter/flatpak_dart/sessions/10fd620c-8043-4937-943d-3a4865baf118 Co-authored-by: jwinarske <12262875+jwinarske@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
jwinarske
March 29, 2026 22:14
View session
Agent-Logs-Url: https://github.com/meta-flutter/flatpak_dart/sessions/a92b7b4b-2598-44ba-af6e-92aadc1dc483 Co-authored-by: jwinarske <12262875+jwinarske@users.noreply.github.com>
…sion - ci.yml: add `dart pub get` before `dart format --set-exit-if-changed` so CI resolves the package to language version 3.4 and uses the old-style formatter, consistent with committed files. - Coverage.cmake: replace --exclude "/usr/*" (shell-expanded in Makefile rules by the Makefile generator, causing lcov 2.0 to reject the expanded paths as extra parameters) with --no-external --base-directory, the standard lcov way to exclude system headers. Agent-Logs-Url: https://github.com/meta-flutter/flatpak_dart/sessions/a92b7b4b-2598-44ba-af6e-92aadc1dc483 Co-authored-by: jwinarske <12262875+jwinarske@users.noreply.github.com>
The Coverage (PR) job failed with: geninfo: ERROR: 'exclude' pattern '*/test/*' is unused. Only the library target (flatpak_nc) has coverage instrumentation, not the test executable, so test source files produce no .gcda files and the '*/test/*' exclude pattern never matches anything. lcov 2.0 treats unused patterns as errors. Fix: remove the dead '*/test/*' exclude, and add --ignore-errors unused so the remaining patterns (*/generated/*, */dart_api_dl*) can't cause the same error in future if the build changes. Agent-Logs-Url: https://github.com/meta-flutter/flatpak_dart/sessions/2df3c636-5e9c-445c-abcd-d75d04f8013d Co-authored-by: jwinarske <12262875+jwinarske@users.noreply.github.com>
|
Coverage after merging copilot/fix-failing-ci-jobs into main will be
Coverage Report for Changed Files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dart pub getbeforedart formatin CI--exclude "/usr/*"with--no-external*/test/*exclude (only the library target has coverage, not the test executable) and added--ignore-errors unusedas belt-and-suspenders💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.