Prevent repeater from adding itself to flood path multiple times#1781
Open
andrewdefilippis wants to merge 1 commit intomeshcore-dev:devfrom
Open
Prevent repeater from adding itself to flood path multiple times#1781andrewdefilippis wants to merge 1 commit intomeshcore-dev:devfrom
andrewdefilippis wants to merge 1 commit intomeshcore-dev:devfrom
Conversation
Drop flood packets where the last 2 path hashes already match this node's hash, stopping repeaters from re-inserting themselves into the path and causing traffic amplification loops. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Author
|
As a quick note, this change would be better aligned with 2-byte repeater ids to have a more protected mesh. It can also be improved by allowing all repeaters to detect 3+ consecutive ids (which should be highly unlikely), and drop the packet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
routeRecvPacket(), check if the last 2 path entries already match — if so, drop the packet instead of retransmittingTest plan
Heltec_v3_repeater)[... 20 20]arriving at repeater with hash0x20is correctly dropped[... AB]at repeater0x20forwards as[... AB 20][... 20]at repeater0x20forwards as[... 20 20]🤖 Generated with Claude Code
Description updated by myself to clarify the underlying issue as a rogue repeater injecting itself into the path multiple times, nearly exhausting max path, and transmitting corrupted messages.
example:
https://discord.com/channels/1343693475589263471/1391673743453192242/1474609553533440020