Experimental lr1121 generic support#1705
Closed
aslater3 wants to merge 4 commits intomeshcore-dev:mainfrom
Closed
Conversation
weebl2000
suggested changes
Mar 5, 2026
|
|
||
| #include <RadioLib.h> | ||
|
|
||
| class CustomLR1121 : public LR1121 { |
Contributor
There was a problem hiding this comment.
How is the radio actually initialized?
| return LR1121::setFrequency(freq); | ||
| } | ||
|
|
||
| int16_t setFrequency(float freq, bool skipCalibration, float band = 4) { |
Contributor
There was a problem hiding this comment.
This isn´t actually overriding.
| return LR1121::setOutputPower(clampTxPower(power)); | ||
| } | ||
|
|
||
| int16_t setOutputPower(int8_t power, bool forceHighPower, uint32_t rampTimeUs = 48) { |
Member
|
Hi there, thanks for the contribution. I'll close this one out since it's experimental, was opened against |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds LR1121-specific TX power handling for multi-band operation by enforcing different maximum TX power limits based on active RF band.
What Changed
CustomLR1121to track the currently configured band fromsetFrequency(...).setOutputPower(...)overloads:20 dBm22 dBmCustomLR1121so non-LR1121 radios and boards are unaffected.Why
This addresses maintainer feedback that LR1121 needs special handling because it supports multiple radios with different TX power limits by band.
Scope / Compatibility
Testing