Skip to content

Add support for writing AIDL FMQs#144

Merged
monich merged 2 commits intomasterfrom
jb61406
Sep 17, 2025
Merged

Add support for writing AIDL FMQs#144
monich merged 2 commits intomasterfrom
jb61406

Conversation

@mlehtima
Copy link
Copy Markdown
Contributor

@mlehtima mlehtima commented Jul 6, 2025

No description provided.

@mlehtima mlehtima requested a review from monich July 6, 2025 19:30
@mlehtima
Copy link
Copy Markdown
Contributor Author

mlehtima commented Jul 6, 2025

Will be used in sailfishos/sensorfw#31

@monich
Copy link
Copy Markdown
Collaborator

monich commented Jul 15, 2025

from the first glance it seems more appropriate to implement this as a protocol specific feature via yet another GBinderRpcProtocol callback.

I generally don't like "virtialuzation" by means of ifs, and on top of that, relying on protocol naming conventions is imo too fragile, especially when those conventions are not clearly spelled out and not guaranteed to be followed.

let me think...

@mlehtima
Copy link
Copy Markdown
Contributor Author

mlehtima commented Sep 11, 2025

@monich I now changed appending fmq descriptor to go via protocol callback. I didn't know if I should make the protocol callback conditional or not, let me know if that needs to be changed.

@monich
Copy link
Copy Markdown
Collaborator

monich commented Sep 12, 2025

looks reasonable from the first glance, please give me a few days, I promise to take a closer look!

Comment thread src/gbinder_rpc_protocol.c Outdated
Comment thread src/gbinder_writer.c Outdated
Comment thread src/gbinder_writer_p.h Outdated
Comment thread src/gbinder_rpc_protocol.h Outdated
Comment thread src/gbinder_rpc_protocol.h Outdated
@mlehtima
Copy link
Copy Markdown
Contributor Author

Also added missing implementation for gbinder_writer_append_fds and updated the version info for that because it was never functional in the old version.

Comment thread include/gbinder_writer.h Outdated
Comment thread src/gbinder_writer.c
Comment thread src/gbinder_rpc_protocol.c
Comment thread src/gbinder_rpc_protocol.c
Copy link
Copy Markdown
Collaborator

@monich monich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust you that it actually works :)

@monich monich merged commit 0ac9ea1 into master Sep 17, 2025
@monich monich deleted the jb61406 branch September 17, 2025 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants