Skip to content

Upgrade to 1.10#64

Merged
okramarenko merged 3 commits into
masterfrom
add1.10
Feb 2, 2026
Merged

Upgrade to 1.10#64
okramarenko merged 3 commits into
masterfrom
add1.10

Conversation

@okramarenko
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request upgrades the dbt-singlestore adapter from version 1.9.1 to 1.10.0. The upgrade includes version number updates and comprehensive documentation for an existing feature (reference tables).

Changes:

  • Updated package version from 1.9.1 to 1.10.0 in both setup.py and __version__.py
  • Added documentation for SingleStore reference table functionality in the README
  • Documented reference table configuration options and restrictions

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
setup.py Updated package_version from "1.9.1" to "1.10.0"
dbt/adapters/singlestore/version.py Updated version string from "1.9.1" to "1.10.0"
README.md Added comprehensive documentation for reference tables, including usage examples, rowstore configuration, and validation rules

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread README.md Outdated
select ...
```

When `reference=true` (default `false`), the adapter generates `CREATE REFERENCE TABLE ...` rather than a regular `CREATE TABLE ...` .
Copy link

Copilot AI Feb 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an extra space before the period at the end of this line. The sentence should end as CREATE TABLE ....` without a space before the period.

Suggested change
When `reference=true` (default `false`), the adapter generates `CREATE REFERENCE TABLE ...` rather than a regular `CREATE TABLE ...` .
When `reference=true` (default `false`), the adapter generates `CREATE REFERENCE TABLE ...` rather than a regular `CREATE TABLE ...`.

Copilot uses AI. Check for mistakes.
Comment thread README.md Outdated
select ...
```

This maps to `CREATE ROWSTORE REFERENCE TABLE ....`
Copy link

Copilot AI Feb 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent use of ellipsis. Line 94 uses three dots (...) while this line uses four dots (....). For consistency, both should use the same number of dots, preferably three as that is the standard ellipsis notation.

Suggested change
This maps to `CREATE ROWSTORE REFERENCE TABLE ....`
This maps to `CREATE ROWSTORE REFERENCE TABLE ...`

Copilot uses AI. Check for mistakes.
@okramarenko okramarenko merged commit 0eadd34 into master Feb 2, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants