Upgrade to 1.10#64
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request upgrades the dbt-singlestore adapter from version 1.9.1 to 1.10.0. The upgrade includes version number updates and comprehensive documentation for an existing feature (reference tables).
Changes:
- Updated package version from 1.9.1 to 1.10.0 in both
setup.pyand__version__.py - Added documentation for SingleStore reference table functionality in the README
- Documented reference table configuration options and restrictions
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| setup.py | Updated package_version from "1.9.1" to "1.10.0" |
| dbt/adapters/singlestore/version.py | Updated version string from "1.9.1" to "1.10.0" |
| README.md | Added comprehensive documentation for reference tables, including usage examples, rowstore configuration, and validation rules |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| select ... | ||
| ``` | ||
|
|
||
| When `reference=true` (default `false`), the adapter generates `CREATE REFERENCE TABLE ...` rather than a regular `CREATE TABLE ...` . |
There was a problem hiding this comment.
There is an extra space before the period at the end of this line. The sentence should end as CREATE TABLE ....` without a space before the period.
| When `reference=true` (default `false`), the adapter generates `CREATE REFERENCE TABLE ...` rather than a regular `CREATE TABLE ...` . | |
| When `reference=true` (default `false`), the adapter generates `CREATE REFERENCE TABLE ...` rather than a regular `CREATE TABLE ...`. |
| select ... | ||
| ``` | ||
|
|
||
| This maps to `CREATE ROWSTORE REFERENCE TABLE ....` |
There was a problem hiding this comment.
Inconsistent use of ellipsis. Line 94 uses three dots (...) while this line uses four dots (....). For consistency, both should use the same number of dots, preferably three as that is the standard ellipsis notation.
| This maps to `CREATE ROWSTORE REFERENCE TABLE ....` | |
| This maps to `CREATE ROWSTORE REFERENCE TABLE ...` |
No description provided.