-
Notifications
You must be signed in to change notification settings - Fork 273
Fix sharding docs inaccuracies #3528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
8ab30b5
Fix sharding docs inaccuracies from review feedback
qdequele b5a8dcc
Fix additional inaccuracies found during code verification
qdequele 5c01c77
Fix error code, add distinct row, document known limitations
qdequele 4f54295
Remove unconfirmed null remote removal pattern, use removeRemotes ins…
qdequele 9d78565
Remove addRemotes/removeRemotes — not real API fields, use full remot…
qdequele 34fa679
Remove all claims not backed by PR 3525 (retry count, distinct attrib…
qdequele 0255a09
Document Linear SCA-21: addRemotes/removeRemotes fields, partition-ba…
qdequele 76656f2
Update resources/self_hosting/sharding/overview.mdx
qdequele ab07fee
Update resources/self_hosting/sharding/overview.mdx
qdequele 1cbda4a
Apply Kerollmops review: remove useNetwork from examples, simplify re…
qdequele File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's actually how it behaves, but I prefer to summon @dureuill on that point.