chore(na): nginx restart in certbot cronjob

[mrjones-plip]

Description

Our TLS docs have certbot attempt to renew the cert, but it does not restart nginx. This means new certs won't get loaded.

This PR adds an nginx reload call to the cronjob.

this issue was discovered in a Medic production instance (see private ticket)

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

[andrablaj]

@1yuv would you be available to review this small PR? Thanks!

[Copilot]

Pull request overview

Updates the TLS/Certbot hosting documentation to ensure nginx reloads after automated certificate renewal so renewed certs are actually picked up by the running nginx container.

Changes:

• Extend the documented certbot cronjob to reload nginx after running certbot.
• Add clarification to verify the nginx container name (cht_nginx_1) before using the cronjob command.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[1yuv]

Hi @mrjones-plip , I tagged @copilot to review and there are some good points that need to address.

[Copilot]

@1yuv I've opened a new pull request, #2153, to work on those changes. Once the pull request is ready, I'll request review from you.

[mrjones-plip]

Thanks for the review @1yuv!

This PR does not mention anything about renewing daily. Indeed, the line 124 literally says Attempt to renew your certificates once a week.

Can you confirm you tested all the suggested copilot changes in an environment with a public IP and DNS entry to ensure the certbot cert gets issued and restarts nginx correctly? That's what I did when authoring this ticket so I want to be sure this level of detail is done when making changes with so many dependencies.

[1yuv]

#2114 (comment) about renewing daily.

First line of this PR description has this

Our TLS docs have certbot attempt to renew every day, but it does not restart nginx. This means new certs won't get loaded.

That's why Copilot was suggesting

Either update the PR description or adjust the documented schedule so they match.

I did not test the copilot suggestions. When I checked them, they appeard like only an enhancement to the commands you used. If you saw anything misleading, please discard the suggestion.

[mrjones-plip]

Ah - I see that now - thanks for taking a second to call it out. I thought it had hallucinated - I'm sorry for my confusion!

I've updated my PR description and given comments on the PR feedback

[1yuv]

Looks good to me.